From: Toshi Kani <toshi.kani@hpe.com>
To: Dave Chinner <david@fromorbit.com>,
Dan Williams <dan.j.williams@intel.com>
Cc: Christoph Hellwig <hch@infradead.org>, Jan Kara <jack@suse.cz>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
micah.parrish@hpe.com, Jens Axboe <axboe@fb.com>,
Andreas Dilger <adilger.kernel@dilger.ca>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Theodore Ts'o <tytso@mit.edu>
Subject: Re: [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks
Date: Mon, 09 May 2016 16:50:44 -0600 [thread overview]
Message-ID: <1462834244.27137.117.camel@hpe.com> (raw)
In-Reply-To: <1462833254.27137.113.camel@hpe.com>
On Mon, 2016-05-09 at 16:34 -0600, Toshi Kani wrote:
> On Tue, 2016-05-10 at 07:19 +1000, Dave Chinner wrote:
:
> > > > >
> > > > > This patch should replace blkdev_dax_capable(), or just reuse
> > > > > that existing routine, or am I missing something?
> > > >
> > > > Good question. bdev_supports_dax() is a helper function tailored
> > > > for the filesystem's mount -o dax case. While blkdev_dax_capable()
> > > > is similar, it does not need error messages like "device does not
> > > > support dax" since it implicitly enables dax when capable. So, I
> > > > think we can keep blkdev_dax_capable(), but change it to call
> > > > bdev_direct_access() so that actual check is performed in a single
> > > > place.
> > >
> > > Sounds good to me.
> >
> > Can you name them consistently then? i.e. blkdev_dax_supported() and
> > blkdev_dax_capable()?
>
> Sure. Will do.
I will keep the "bdev_" prefix to be consistent with bdev_direct_access(),
i.e. bdev_dax_supported() and bdev_dax_capable().
-Toshi
next prev parent reply other threads:[~2016-05-09 22:59 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-06 0:29 [PATCH v3 0/5] Add alignment check for DAX mount Toshi Kani
2016-05-06 0:29 ` [PATCH v3 1/5] block: Add vfs_msg() interface Toshi Kani
2016-05-08 8:56 ` Christoph Hellwig
2016-05-06 0:29 ` [PATCH v3 2/5] block: Add bdev_supports_dax() for dax mount checks Toshi Kani
2016-05-08 8:57 ` Christoph Hellwig
2016-05-08 19:14 ` Dan Williams
2016-05-09 18:12 ` Toshi Kani
2016-05-09 18:23 ` Dan Williams
2016-05-09 21:19 ` Dave Chinner
2016-05-09 22:34 ` Toshi Kani
2016-05-09 22:50 ` Toshi Kani [this message]
2016-05-06 0:29 ` [PATCH v3 3/5] ext4: Add alignment check for DAX mount Toshi Kani
2016-05-09 8:15 ` Jan Kara
2016-05-06 0:29 ` [PATCH v3 4/5] ext2: " Toshi Kani
2016-05-08 8:59 ` Christoph Hellwig
2016-05-09 8:23 ` Jan Kara
2016-05-09 8:31 ` Jan Kara
2016-05-06 0:29 ` [PATCH v3 5/5] xfs: " Toshi Kani
2016-05-08 8:58 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1462834244.27137.117.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=adilger.kernel@dilger.ca \
--cc=axboe@fb.com \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=micah.parrish@hpe.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).