From: Andreas Gruenbacher <agruenba@redhat.com>
To: Mike Marshall <hubcap@omnibond.com>
Cc: Andreas Gruenbacher <agruenba@redhat.com>, linux-fsdevel@vger.kernel.org
Subject: [PATCH 2/3] orangefs: Remove redundant "trusted." xattr handler
Date: Wed, 25 May 2016 12:29:33 +0200 [thread overview]
Message-ID: <1464172174-29237-3-git-send-email-agruenba@redhat.com> (raw)
In-Reply-To: <1464172174-29237-1-git-send-email-agruenba@redhat.com>
Orangefs has a catch-all xattr handler that effectively does what the
trusted handler does already.
Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
---
fs/orangefs/xattr.c | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/fs/orangefs/xattr.c b/fs/orangefs/xattr.c
index 2944d0a..1d8be91 100644
--- a/fs/orangefs/xattr.c
+++ b/fs/orangefs/xattr.c
@@ -477,41 +477,6 @@ static int orangefs_xattr_get_default(const struct xattr_handler *handler,
}
-static int orangefs_xattr_set_trusted(const struct xattr_handler *handler,
- struct dentry *dentry,
- const char *name,
- const void *buffer,
- size_t size,
- int flags)
-{
- return orangefs_inode_setxattr(dentry->d_inode,
- XATTR_TRUSTED_PREFIX,
- name,
- buffer,
- size,
- flags);
-}
-
-static int orangefs_xattr_get_trusted(const struct xattr_handler *handler,
- struct dentry *unused,
- struct inode *inode,
- const char *name,
- void *buffer,
- size_t size)
-{
- return orangefs_inode_getxattr(inode,
- XATTR_TRUSTED_PREFIX,
- name,
- buffer,
- size);
-}
-
-static struct xattr_handler orangefs_xattr_trusted_handler = {
- .prefix = XATTR_TRUSTED_PREFIX,
- .get = orangefs_xattr_get_trusted,
- .set = orangefs_xattr_set_trusted,
-};
-
static struct xattr_handler orangefs_xattr_default_handler = {
.prefix = "", /* match any name => handlers called with full name */
.get = orangefs_xattr_get_default,
@@ -521,7 +486,6 @@ static struct xattr_handler orangefs_xattr_default_handler = {
const struct xattr_handler *orangefs_xattr_handlers[] = {
&posix_acl_access_xattr_handler,
&posix_acl_default_xattr_handler,
- &orangefs_xattr_trusted_handler,
&orangefs_xattr_default_handler,
NULL
};
--
2.5.5
next prev parent reply other threads:[~2016-05-25 10:29 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-25 10:29 [PATCH 0/3] Minor orangefs xattr cleanups Andreas Gruenbacher
2016-05-25 10:29 ` [PATCH 1/3] orangefs: Remove useless defines Andreas Gruenbacher
2016-05-26 19:44 ` Mike Marshall
2016-05-26 20:05 ` Al Viro
2016-05-26 22:24 ` Mike Marshall
2016-05-26 23:53 ` Al Viro
2016-05-27 21:24 ` Mike Marshall
2016-05-28 14:25 ` Mike Marshall
2016-05-25 10:29 ` Andreas Gruenbacher [this message]
2016-05-25 10:29 ` [PATCH 3/3] orangefs: Remove useless xattr prefix arguments Andreas Gruenbacher
2016-05-25 15:21 ` [PATCH 0/3] Minor orangefs xattr cleanups Mike Marshall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464172174-29237-3-git-send-email-agruenba@redhat.com \
--to=agruenba@redhat.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).