From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from k21.active24.pl ([195.78.67.21]:41940 "EHLO k21.active24.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751412AbcFAJXi (ORCPT ); Wed, 1 Jun 2016 05:23:38 -0400 Subject: Re: freevxfs: hp-ux support. patchset 1-7/7 rev 2 From: Krzysztof =?UTF-8?Q?B=C5=82aszkowski?= To: Christoph Hellwig Cc: Carlos Maiolino , linux-fsdevel@vger.kernel.org In-Reply-To: <20160601073310.GA6787@infradead.org> References: <1464273946.17980.15.camel@linux-q3cb.site> <1464464428.3689.14.camel@linux-q3cb.site> <20160531122510.GA25651@infradead.org> <1464702291.900.75.camel@linux-q3cb.site> <20160601073310.GA6787@infradead.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 01 Jun 2016 11:23:32 +0200 Message-ID: <1464773012.900.105.camel@linux-q3cb.site> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Christoph, On Wed, 2016-06-01 at 00:33 -0700, Christoph Hellwig wrote: > Yeah, this was just getting started. I've spent some more time on the > whole inode issues and have implemented this a bit different from what > you did, although the end result is very similar. Can you take a look > at the tree here: > > http://git.infradead.org/users/hch/vfs.git/shortlog/refs/heads/freevxfs > > > Do you think other patches should be updated with regard to the patch > > you sent ? > > Please take a look at the branch above. I think that there are no "kfree(pfp); kfree(sfp); return 0;" in vxfs_read_fshead() still. Are pfp and sfp needed anywhere ? I am sure they are not so there is a memory leak without these kfrees every mount. I am not sure absolutely of that read_fshead() is missing these kfrees because I have seen just these diffs, anyway I did not notice "+kfree". so .. whose patch is more accurate ? needles to say that I prefer to have limited scope of visibility of inode_cachep to the inode.c only. Thanks, -- Krzysztof Blaszkowski