From: Jaegeuk Kim <jaegeuk@kernel.org>
To: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Cc: Jaegeuk Kim <jaegeuk@kernel.org>
Subject: [PATCH 1/8] f2fs: reuse nid if it was cached only
Date: Thu, 2 Jun 2016 20:55:32 -0700 [thread overview]
Message-ID: <1464926139-58252-1-git-send-email-jaegeuk@kernel.org> (raw)
If nid's block address is assigned as:
NULL_ADDR -> NEW_ADDR -> NULL_ADDR, we can reset this nid, since its node page
has never written back.
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
---
fs/f2fs/node.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/fs/f2fs/node.c b/fs/f2fs/node.c
index 16532b3..15f55ae 100644
--- a/fs/f2fs/node.c
+++ b/fs/f2fs/node.c
@@ -317,10 +317,16 @@ static void set_node_addr(struct f2fs_sb_info *sbi, struct node_info *ni,
}
/* change address */
- nat_set_blkaddr(e, new_blkaddr);
- if (new_blkaddr == NEW_ADDR || new_blkaddr == NULL_ADDR)
- set_nat_flag(e, IS_CHECKPOINTED, false);
- __set_nat_cache_dirty(nm_i, e);
+ if (nat_get_blkaddr(e) == NEW_ADDR && new_blkaddr == NULL_ADDR) {
+ nat_set_blkaddr(e, new_blkaddr);
+ nat_reset_flag(e);
+ __clear_nat_cache_dirty(nm_i, e);
+ } else {
+ nat_set_blkaddr(e, new_blkaddr);
+ if (new_blkaddr == NEW_ADDR || new_blkaddr == NULL_ADDR)
+ set_nat_flag(e, IS_CHECKPOINTED, false);
+ __set_nat_cache_dirty(nm_i, e);
+ }
/* update fsync_mark if its inode nat entry is still alive */
if (ni->nid != ni->ino)
--
2.6.3
next reply other threads:[~2016-06-03 3:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 3:55 Jaegeuk Kim [this message]
2016-06-03 3:55 ` [PATCH 2/8] f2fs: remove deprecated parameter Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 3/8] f2fs: avoid wrong count on dirty inodes Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 4/8] f2fs: skip roll_forward recovery after umount Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 5/8] f2fs: remove obsolete parameter in f2fs_truncate Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 6/8] f2fs: avoid data race between FI_DIRTY_INODE flag and update_inode Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 7/8] f2fs: fix wrong percentage Jaegeuk Kim
2016-06-03 3:55 ` [PATCH 8/8] f2fs: control not to exceed # of cached nat entries Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464926139-58252-1-git-send-email-jaegeuk@kernel.org \
--to=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).