From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from k22.active24.pl ([195.78.67.22]:40295 "EHLO k22.active24.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbcFJOrI (ORCPT ); Fri, 10 Jun 2016 10:47:08 -0400 Subject: Re: freevxfs: hp-ux support. ( 1cce17017970c07) patchset 2/4 From: Krzysztof =?UTF-8?Q?B=C5=82aszkowski?= To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, Carlos Maiolino Content-Type: text/plain; charset="UTF-8" Date: Fri, 10 Jun 2016 16:47:04 +0200 Message-ID: <1465570024.5573.25.camel@linux-q3cb.site> Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: this is far more important and I decided that it is enough to use inode_init_once() in alloc_inode() because this is the only one place which uses kmem_cache_alloc() thus the callback for kmem_cache_create() is not required. >>From 36de33b8a96c5a1df89dc5b0b01aaa2f2ab44b7d Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krzysztof=20B=C5=82aszkowski?= Date: Fri, 10 Jun 2016 13:13:31 +0200 Subject: [PATCH 2/4] fix lack of inode initialization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit there is nothing worse than just allocated inode without being initialized _once() Signed-off-by: Krzysztof Błaszkowski --- fs/freevxfs/vxfs_super.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/freevxfs/vxfs_super.c b/fs/freevxfs/vxfs_super.c index e5eef14..455ce5b 100644 --- a/fs/freevxfs/vxfs_super.c +++ b/fs/freevxfs/vxfs_super.c @@ -127,6 +127,7 @@ static struct inode *vxfs_alloc_inode(struct super_block *sb) vi = kmem_cache_alloc(vxfs_inode_cachep, GFP_KERNEL); if (!vi) return NULL; + inode_init_once(&vi->vfs_inode); return &vi->vfs_inode; } -- 2.8.3 -- Krzysztof Blaszkowski