From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from alt22.smtp-out.videotron.ca ([70.80.0.73]:40102 "EHLO alt22.smtp-out.videotron.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751837AbcGLVnY (ORCPT ); Tue, 12 Jul 2016 17:43:24 -0400 From: Nicolas Pitre To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Alexander Viro , David Howells , Greg Ungerer Subject: [PATCH 07/10] binfmt_flat: use clear_user() rather than memset() to clear .bss Date: Tue, 12 Jul 2016 17:27:39 -0400 Message-Id: <1468358862-11799-8-git-send-email-nicolas.pitre@linaro.org> In-Reply-To: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> References: <1468358862-11799-1-git-send-email-nicolas.pitre@linaro.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: This is needed on systems with a MMU. Signed-off-by: Nicolas Pitre --- fs/binfmt_flat.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c index c85f8f1239..e981e66bb5 100644 --- a/fs/binfmt_flat.c +++ b/fs/binfmt_flat.c @@ -803,10 +803,11 @@ static int load_flat_file(struct linux_binprm * bprm, flush_icache_range(start_code, end_code); /* zero the BSS, BRK and stack areas */ - memset((void*)(datapos + data_len), 0, bss_len + + if (clear_user((void __user *)(datapos + data_len), bss_len + (memp + memp_size - stack_len - /* end brk */ libinfo->lib_list[id].start_brk) + /* start brk */ - stack_len); + stack_len)) + return -EFAULT; return 0; err: -- 2.7.4