From: Jeff Layton <jlayton@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: linux-fsdevel@vger.kernel.org, libc-alpha@sourceware.org,
chrubis@suse.cz
Subject: Re: [Linux PATCH] fcntl: add new F_OFD_*32 constants and handle them appropriately
Date: Thu, 18 Aug 2016 13:28:20 -0400 [thread overview]
Message-ID: <1471541300.2504.23.camel@redhat.com> (raw)
In-Reply-To: <20160818170508.GA897@lst.de>
On Thu, 2016-08-18 at 19:05 +0200, Christoph Hellwig wrote:
> NAK. People should stop using 32-bit off_t and friends yesterday.
> It's a shame that glibc hasn't cought up with last century yet and
> stopped providing the non-LFS APIs for newly compiled code, but
> we certainly should not bloat the kernel for the idiotic behavior.
>
> In addition anyone is going to use a new Linux-only feature like the
> OFS locks should be using LFS support anyway.
That was my original thinking, but several people seemed to think that
we should just go ahead and support it. TBH, I don't much care either
way, but we either need to support it properly, or ensure that trying
to use OFD locks in a non-LFS program fails to compile.
The only real concern I have here is whether limiting this to LFS
enabled programs might make it tougher to get this into POSIX. Would
the POSIX standards folks object to having an interface like this that
doesn't support non-LFS cases? I guess if that ever happens though,
then we can just widen the support at that point.
If this is the consensus, then we can go with something like the glibc
patch I sent yesterday, which disables the command definitions when LFS
is not in effect.
Thoughts?
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2016-08-19 4:03 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-18 12:03 [Linux PATCH] fcntl: add new F_OFD_*32 constants and handle them appropriately Jeff Layton
2016-08-18 13:24 ` Cyril Hrubis
2016-08-18 13:54 ` Jeff Layton
2016-08-18 14:06 ` Cyril Hrubis
2016-08-18 17:05 ` Christoph Hellwig
2016-08-18 17:28 ` Jeff Layton [this message]
2016-08-18 17:31 ` Christoph Hellwig
2016-08-18 17:46 ` Mike Frysinger
2016-08-18 17:52 ` Christoph Hellwig
2016-08-18 18:16 ` Mike Frysinger
2016-08-18 19:01 ` Zack Weinberg
2016-08-18 19:36 ` Paul Eggert
2016-08-19 13:20 ` Zack Weinberg
2016-08-19 15:02 ` Joseph Myers
2016-08-19 15:45 ` Zack Weinberg
2016-08-19 16:58 ` Joseph Myers
2016-08-19 19:50 ` Zack Weinberg
2016-08-18 20:52 ` Joseph Myers
2016-08-25 11:53 ` Florian Weimer
2016-08-25 12:05 ` Cyril Hrubis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471541300.2504.23.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=chrubis@suse.cz \
--cc=hch@lst.de \
--cc=libc-alpha@sourceware.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).