From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-yb0-f178.google.com ([209.85.213.178]:36446 "EHLO mail-yb0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754186AbcHSEDc (ORCPT ); Fri, 19 Aug 2016 00:03:32 -0400 Received: by mail-yb0-f178.google.com with SMTP id e31so12027648ybi.3 for ; Thu, 18 Aug 2016 21:03:31 -0700 (PDT) Message-ID: <1471541300.2504.23.camel@redhat.com> Subject: Re: [Linux PATCH] fcntl: add new F_OFD_*32 constants and handle them appropriately From: Jeff Layton To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, libc-alpha@sourceware.org, chrubis@suse.cz Date: Thu, 18 Aug 2016 13:28:20 -0400 In-Reply-To: <20160818170508.GA897@lst.de> References: <1471521804-4291-1-git-send-email-jlayton@redhat.com> <20160818170508.GA897@lst.de> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, 2016-08-18 at 19:05 +0200, Christoph Hellwig wrote: > NAK.  People should stop using 32-bit off_t and friends yesterday. > It's a shame that glibc hasn't cought up with last century yet and > stopped providing the non-LFS APIs for newly compiled code, but  > we certainly should not bloat the kernel for the idiotic behavior. > > In addition anyone is going to use a new Linux-only feature like the > OFS locks should be using LFS support anyway. That was my original thinking, but several people seemed to think that we should just go ahead and support it. TBH, I don't much care either way, but we either need to support it properly, or ensure that trying to use OFD locks in a non-LFS program fails to compile. The only real concern I have here is whether limiting this to LFS enabled programs might make it tougher to get this into POSIX. Would the POSIX standards folks object to having an interface like this that doesn't support non-LFS cases? I guess if that ever happens though, then we can just widen the support at that point. If this is the consensus, then we can go with something like the glibc patch I sent yesterday, which disables the command definitions when LFS is not in effect. Thoughts? -- Jeff Layton