From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "ross.zwisler@linux.intel.com" <ross.zwisler@linux.intel.com>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
"adilger.kernel@dilger.ca" <adilger.kernel@dilger.ca>,
"viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
"dan.j.williams@intel.com" <dan.j.williams@intel.com>,
"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
"mawilcox@microsoft.com" <mawilcox@microsoft.com>,
"linux-nvdimm@lists.01.org" <linux-nvdimm@lists.01.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
"jack@suse.com" <jack@suse.com>, "tytso@mit.edu" <tytso@mit.edu>,
"linux-ext4@vger.kernel.org" <linux-ext4@vger.kernel.org>,
"david@fromorbit.com" <david@fromorbit.com>
Subject: Re: [PATCH v2 0/9] re-enable DAX PMD support
Date: Wed, 31 Aug 2016 22:08:59 +0000 [thread overview]
Message-ID: <1472681284.2092.30.camel@hpe.com> (raw)
In-Reply-To: <20160831213607.GA6921@linux.intel.com>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1878 bytes --]
On Wed, 2016-08-31 at 15:36 -0600, Ross Zwisler wrote:
> On Wed, Aug 31, 2016 at 08:20:48PM +0000, Kani, Toshimitsu wrote:
> >
> > On Tue, 2016-08-30 at 17:01 -0600, Ross Zwisler wrote:
> > >
> > > On Tue, Aug 23, 2016 at 04:04:10PM -0600, Ross Zwisler wrote:
 :
> > >
> > > Ping on this series?  Any objections or comments?
> >
> > Hi Ross,
> >
> > I am seeing a major performance loss in fio mmap test with this
> > patch-set applied. Â This happens with or without my patches [1]
> > applied on top of yours.  Without my patches, dax_pmd_fault() falls
> > back to the pte handler since an mmap'ed address is not 2MB-
> > aligned.
> >
> > I have attached three test results.
> > Â o rc4.log - 4.8.0-rc4 (base)
> > Â o non-pmd.log - 4.8.0-rc4 + your patchset (fall back to pte)
> > Â o pmd.log - 4.8.0-rc4 + your patchset + my patchset (use pmd maps)
> >
> > My test steps are as follows.
> >
> > mkfs.ext4 -O bigalloc -C 2M /dev/pmem0
> > mount -o dax /dev/pmem0 /mnt/pmem0
> > numactl --preferred block:pmem0 --cpunodebind block:pmem0 fio
> > test.fio
> >
> > "test.fio"
> > ---
> > [global]
> > bs=4k
> > size=2G
> > directory=/mnt/pmem0
> > ioengine=mmap
> > [randrw]
> > rw=randrw
> > ---
> >
> > Can you please take a look?
>
> Yep, thanks for the report.
I have some more observations. Â It seems this issue is related with pmd
mappings after all. Â fio creates "randrw.0.0" file. Â In my setup, an
initial test run creates pmd mappings and hits this issue. Â Subsequent
test runs (i.e. randrw.0.0 exists), without my patches, fall back to
pte mappings and do not hit this issue. Â With my patches applied,
subsequent runs still create pmd mappings and hit this issue.
Thanks,
-Toshi Â
N§²æìr¸zǧu©²Æ {\béì¹»\x1c®&Þ)îÆi¢Ø^nr¶Ý¢j$½§$¢¸\x05¢¹¨è§~'.)îÄÃ,yèm¶ÿÃ\f%{±j+ðèצj)Z·
next prev parent reply other threads:[~2016-08-31 22:08 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 22:04 [PATCH v2 0/9] re-enable DAX PMD support Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 1/9] ext4: allow DAX writeback for hole punch Ross Zwisler
2016-09-21 15:22 ` Ross Zwisler
2016-09-22 6:59 ` Jan Kara
2016-09-22 15:51 ` Theodore Ts'o
2016-08-23 22:04 ` [PATCH v2 2/9] ext2: tell DAX the size of allocation holes Ross Zwisler
2016-08-25 7:57 ` Christoph Hellwig
2016-08-25 19:25 ` Ross Zwisler
2016-08-26 21:29 ` Ross Zwisler
2016-08-29 0:42 ` Dave Chinner
2016-08-29 7:41 ` Christoph Hellwig
2016-08-29 12:57 ` Theodore Ts'o
2016-08-30 7:21 ` Christoph Hellwig
2016-09-09 16:48 ` Ross Zwisler
2016-09-09 20:35 ` Matthew Wilcox
2016-09-09 22:34 ` Dan Williams
2016-09-10 7:31 ` Christoph Hellwig
2016-09-10 7:50 ` Matthew Wilcox
2016-09-10 17:49 ` Theodore Ts'o
[not found] ` <20160910174910.yyirb7smiob7evt5-AKGzg7BKzIDYtjvyW6yDsg@public.gmane.org>
2016-09-11 0:42 ` Matthew Wilcox
[not found] ` <CAPcyv4hjna08+Yw23w_V2f-RbBE6ar220+YGCuBVA-TACKWNug-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-09-10 8:15 ` Matthew Wilcox
2016-09-10 14:56 ` Dan Williams
2016-09-10 7:30 ` Christoph Hellwig
2016-09-10 7:33 ` Matthew Wilcox
2016-09-10 7:42 ` Christoph Hellwig
2016-09-10 7:52 ` Matthew Wilcox
2016-09-11 12:47 ` Christoph Hellwig
2016-09-11 22:57 ` Ross Zwisler
2016-09-10 15:55 ` Matthew Wilcox
2016-09-15 20:09 ` Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 3/9] ext4: " Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 4/9] dax: remove buffer_size_valid() Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 5/9] dax: make 'wait_table' global variable static Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 6/9] dax: consistent variable naming for DAX entries Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 7/9] dax: coordinate locking for offsets in PMD range Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 8/9] dax: re-enable DAX PMD support Ross Zwisler
2016-08-23 22:04 ` [PATCH v2 9/9] dax: remove "depends on BROKEN" from FS_DAX_PMD Ross Zwisler
2016-08-30 23:01 ` [PATCH v2 0/9] re-enable DAX PMD support Ross Zwisler
2016-08-31 20:20 ` Kani, Toshimitsu
2016-08-31 21:36 ` Ross Zwisler
2016-08-31 22:08 ` Kani, Toshimitsu [this message]
2016-09-01 16:21 ` Ross Zwisler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1472681284.2092.30.camel@hpe.com \
--to=toshi.kani@hpe.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@fromorbit.com \
--cc=jack@suse.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-nvdimm@lists.01.org \
--cc=mawilcox@microsoft.com \
--cc=ross.zwisler@linux.intel.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).