From: Jan Kara <jack@suse.cz>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.org,
Dave Chinner <david@fromorbit.com>,
Ilya Dryomov <idryomov@gmail.com>, Sage Weil <sage@redhat.com>,
"Yan, Zheng" <zyan@redhat.com>,
ceph-devel@vger.kernel.org, Miklos Szeredi <miklos@szeredi.hu>,
Jan Kara <jack@suse.cz>
Subject: [PATCH 0/5 v2 RESEND] fs: Avoid premature clearing of file capabilities
Date: Mon, 19 Sep 2016 17:30:54 +0200 [thread overview]
Message-ID: <1474299059-14806-1-git-send-email-jack@suse.cz> (raw)
Hello,
I'm resending the patches since Al did not respond to the series yet (I've
previously posted it in [1] on Aug 3. Al? If Al does not respond, can you
Andrew please feed to patches to Linus? Thanks.
This patch series is my attempt to fix an issue when user can clear capabilites
of arbitrary file he can look up for example by running chown on it (this got
assigned CVE-2015-1350). The problem is that we call security_inode_killpriv()
before checking permissions in inode_change_ok(). This patch set moves that
call into inode_change_ok() after permissions are checked - the only trouble is
that we need to give dentry instead of inode there and that is not completely
trivial in some cases - I'm still missing a review from Ceph people to verify I
didn't miss anything.
Anyway, I guess the changes are fine for merging. Al, you please merge the
patches? Thanks!
Changes since v1:
* Added acks for XFS and FUSE patches
Honza
[1] https://www.spinics.net/lists/ceph-devel/msg31650.html
next reply other threads:[~2016-09-19 15:31 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 15:30 Jan Kara [this message]
2016-09-19 15:30 ` [PATCH 1/5] xfs: Propagate dentry down to inode_change_ok() Jan Kara
2016-09-19 15:30 ` [PATCH 2/5] ceph: " Jan Kara
2016-09-19 18:57 ` Jeff Layton
2016-09-22 8:50 ` Jan Kara
2016-09-22 17:20 ` Jeff Layton
2016-09-26 10:25 ` Jan Kara
2016-09-23 7:45 ` Yan, Zheng
2016-09-19 15:30 ` [PATCH 3/5] fuse: " Jan Kara
2016-09-19 15:30 ` [PATCH 4/5] fs: Give dentry to inode_change_ok() instead of inode Jan Kara
2016-09-19 15:30 ` [PATCH 5/5] fs: Avoid premature clearing of capabilities Jan Kara
2016-09-19 15:38 ` [PATCH 0/5 v2 RESEND] fs: Avoid premature clearing of file capabilities Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474299059-14806-1-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=akpm@linux-foundation.org \
--cc=ceph-devel@vger.kernel.org \
--cc=david@fromorbit.com \
--cc=idryomov@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=sage@redhat.com \
--cc=viro@ZenIV.linux.org.uk \
--cc=xfs@oss.sgi.org \
--cc=zyan@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).