From: Jan Kara <jack@suse.cz>
To: linux-fsdevel@vger.kernel.org
Cc: linux-nvdimm@lists.01.org,
Dan Williams <dan.j.williams@intel.com>,
Ross Zwisler <ross.zwisler@linux.intel.com>,
Jan Kara <jack@suse.cz>
Subject: [PATCH 3/6] ext4: Remove clearing of BH_New bit for zeroed blocks
Date: Tue, 27 Sep 2016 18:43:32 +0200 [thread overview]
Message-ID: <1474994615-29553-4-git-send-email-jack@suse.cz> (raw)
In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz>
So far we did not return BH_New buffers from ext4_dax_get_block()
because that would trigger racy zeroing in DAX code. This zeroing is
gone these days so we can remove the workaround.
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/ext4/inode.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 87150122d361..7ccd6fd7819d 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3298,11 +3298,6 @@ int ext4_dax_get_block(struct inode *inode, sector_t iblock,
if (ret < 0)
return ret;
}
- /*
- * At least for now we have to clear BH_New so that DAX code
- * doesn't attempt to zero blocks again in a racy way.
- */
- clear_buffer_new(bh_result);
return 0;
}
#else
--
2.6.6
next prev parent reply other threads:[~2016-09-27 16:43 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-27 16:43 [PATCH 0/6] dax: Page invalidation fixes Jan Kara
2016-09-27 16:43 ` [PATCH 1/6] dax: Do not warn about BH_New buffers Jan Kara
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 2/6] ext2: Return BH_New buffers for zeroed blocks Jan Kara
2016-09-30 8:53 ` Christoph Hellwig
2016-09-27 16:43 ` Jan Kara [this message]
2016-09-30 8:53 ` [PATCH 3/6] ext4: Remove clearing of BH_New bit " Christoph Hellwig
2016-09-27 16:43 ` [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Jan Kara
2016-09-27 17:01 ` Christoph Hellwig
2016-09-27 17:17 ` Jan Kara
2016-09-28 0:22 ` Dave Chinner
2016-10-03 14:44 ` Jan Kara
2016-09-28 2:13 ` Christoph Hellwig
2016-10-03 14:42 ` Jan Kara
2016-10-03 16:39 ` Christoph Hellwig
2016-09-27 16:43 ` [PATCH 5/6] mm: Invalidate DAX radix tree entries only if appropriate Jan Kara
2016-09-28 0:18 ` Dave Chinner
2016-10-03 14:52 ` Jan Kara
2016-09-30 8:57 ` Christoph Hellwig
2016-10-03 12:56 ` Jan Kara
2016-09-27 16:43 ` [PATCH 6/6] dax: Avoid page invalidation races and unnecessary radix tree traversals Jan Kara
2016-09-28 0:20 ` Dave Chinner
2016-10-03 14:58 ` Jan Kara
2016-10-03 23:40 ` Dave Chinner
2016-09-30 8:55 ` Christoph Hellwig
2016-10-03 15:02 ` Jan Kara
2016-09-30 8:59 ` [PATCH 0/6] dax: Page invalidation fixes Christoph Hellwig
2016-10-03 13:01 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1474994615-29553-4-git-send-email-jack@suse.cz \
--to=jack@suse.cz \
--cc=dan.j.williams@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=ross.zwisler@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).