From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:42399 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936212AbcI0Qnu (ORCPT ); Tue, 27 Sep 2016 12:43:50 -0400 From: Jan Kara To: linux-fsdevel@vger.kernel.org Cc: linux-nvdimm@lists.01.org, Dan Williams , Ross Zwisler , Jan Kara Subject: [PATCH 4/6] xfs: Set BH_New for allocated DAX blocks in __xfs_get_blocks() Date: Tue, 27 Sep 2016 18:43:33 +0200 Message-Id: <1474994615-29553-5-git-send-email-jack@suse.cz> In-Reply-To: <1474994615-29553-1-git-send-email-jack@suse.cz> References: <1474994615-29553-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: So far we did not set BH_New for newly allocated blocks for DAX inodes in __xfs_get_blocks() because we wanted to avoid zeroing done in generic DAX code which was racy. Now the zeroing is gone so we can remove this workaround and return BH_New for newly allocated blocks. DAX will use this information to properly update mappings of the file. Signed-off-by: Jan Kara --- fs/xfs/xfs_aops.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/fs/xfs/xfs_aops.c b/fs/xfs/xfs_aops.c index 4a28fa91e3b1..b25b7b5a1e6e 100644 --- a/fs/xfs/xfs_aops.c +++ b/fs/xfs/xfs_aops.c @@ -1245,11 +1245,8 @@ __xfs_get_blocks( goto out_unlock; } - if (IS_DAX(inode) && create) { + if (IS_DAX(inode) && create) ASSERT(!ISUNWRITTEN(&imap)); - /* zeroing is not needed at a higher layer */ - new = 0; - } /* trim mapping down to size requested */ xfs_map_trim_size(inode, iblock, bh_result, &imap, offset, size); -- 2.6.6