From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f177.google.com ([209.85.220.177]:33756 "EHLO mail-qk0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753357AbcKRMBy (ORCPT ); Fri, 18 Nov 2016 07:01:54 -0500 Received: by mail-qk0-f177.google.com with SMTP id x190so259183198qkb.0 for ; Fri, 18 Nov 2016 04:01:53 -0800 (PST) Message-ID: <1479470509.2563.3.camel@redhat.com> Subject: Re: [PATCH 1/4] statx: Add a system call to make enhanced file info available From: Jeff Layton To: David Howells Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 18 Nov 2016 07:01:49 -0500 In-Reply-To: <25389.1479458901@warthog.procyon.org.uk> References: <1479407964.4556.5.camel@redhat.com> <147938969703.13574.10295364502230379833.stgit@warthog.procyon.org.uk> <147938970382.13574.11581172952175034619.stgit@warthog.procyon.org.uk> <25389.1479458901@warthog.procyon.org.uk> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Fri, 2016-11-18 at 08:48 +0000, David Howells wrote: > Jeff Layton wrote: > > > > > > > > > If neither AT_STATX_*_SYNC flag is set, the behaviour is the default for > > > stat() on that filesystem. > > > > > > > We also need to specify here what happens if both bits are set. Should > > that be -EINVAL? > > Makes sense. > > This leads to another thought: should fstatat() be allowed to take AT_STATX_* > flags? > > David In principle, we could. fstatat currently rejects flags that it doesn't understand with -EINVAL. That said, I'd vote no -- if you wanted to change an application to start setting these flags in fstatat calls, then it's just as simple to convert it over to use statx. I don't see a lot of benefit in adding that to a legacy syscall. -- Jeff Layton