linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Fabian Frederick <fabf@skynet.be>
To: tytso@mit.edu
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
	fabf@skynet.be
Subject: [PATCH 1/1 linux-next] ext4: fix journal data documentation regarding O_DIRECT
Date: Fri, 25 Nov 2016 20:53:59 +0100	[thread overview]
Message-ID: <1480103639-25499-1-git-send-email-fabf@skynet.be> (raw)

O_DIRECT is declared disabled in data=journal mode but still served
as buffered-IO when one would expect such operations to be canceled.
This patch clarifies documentation and removes redundancy.

Thanks to Theodore Ts'o for explanations.

Signed-off-by: Fabian Frederick <fabf@skynet.be>
---
 Documentation/filesystems/ext4.txt | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/Documentation/filesystems/ext4.txt b/Documentation/filesystems/ext4.txt
index 6c0108e..12bb488 100644
--- a/Documentation/filesystems/ext4.txt
+++ b/Documentation/filesystems/ext4.txt
@@ -157,10 +157,7 @@ noload			if the filesystem was not unmounted cleanly,
                      	filesystem containing inconsistencies that can
                      	lead to any number of problems.
 
-data=journal		All data are committed into the journal prior to being
-			written into the main file system.  Enabling
-			this mode will disable delayed allocation and
-			O_DIRECT support.
+data=journal		See journal mode below.
 
 data=ordered	(*)	All data are forced directly out to the main file
 			system prior to its metadata being committed to the
@@ -415,7 +412,8 @@ In the event of a crash, the journal can be replayed, bringing both data and
 metadata into a consistent state.  This mode is the slowest except when data
 needs to be read from and written to disk at the same time where it
 outperforms all others modes.  Enabling this mode will disable delayed
-allocation and O_DIRECT support.
+allocation and O_DIRECT support; the later being silently served using
+buffered-IO.
 
 /proc entries
 =============
-- 
2.7.4

                 reply	other threads:[~2016-11-25 19:53 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1480103639-25499-1-git-send-email-fabf@skynet.be \
    --to=fabf@skynet.be \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tytso@mit.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).