[RFC][PATCH 0/4] fsnotify: pass single mark to handle_event()

[Amir Goldstein <amir73il@gmail.com>]

Jan,

I thought this would turn out simpler, so you may be able to use it
for your work, but I'm afraid that's not the case.

Anyway, since I am leaving for new year's vacation, I am posting
what I have in case you want to use any of it.

It passed some initial tests I ran, but when I wanted to test the
corner case referred to in patch 1, I found that my test program
hangs open() syscalls with kernel 4.10-rc1 before any of my changes.

This is the mark setup I was testing [1]:
  fanotify_mark(fd, FAN_MARK_ADD,
                FAN_OPEN_PERM | FAN_EVENT_ON_CHILD, AT_FDCWD,
                path);
  fanotify_mark(fd, FAN_MARK_ADD | \
                FAN_MARK_IGNORED_SURV_MODIFY | FAN_MARK_IGNORED_MASK
                FAN_OPEN_PERM | FAN_EVENT_ON_CHILD, AT_FDCWD,
                FAN_CLOSE_WRITE, AT_FDCWD,
                path);
  fanotify_mark(fd, FAN_MARK_ADD | FAN_MARK_MOUNT,
                FAN_OPEN_PERM | FAN_CLOSE_WRITE, AT_FDCWD,
                path);

Without FAN_EVENT_ON_CHILD it works fine, but with FAN_EVENT_ON_CHILD,
something bad is going on and I did not have time to look into it.

In general, I would like to start working on an fsnotify testsuite,
so if you have any plans wrt writing extra tests or ideas about specific
missing tests, please let me know about them.

Thanks,
Amir.

[1] https://github.com/amir73il/fsnotify-utils/blob/master/fanotify_example.c

Amir Goldstein (4):
  fsnotify: process inode/vfsmount marks independently
  fsnotify: helper to update marks ignored_mask
  fsnotify: return FSNOTIFY_DROPPED when handle_event() dropped event
  fsnotify: pass single mark to handle_event()

 fs/notify/dnotify/dnotify.c          |   4 +-
 fs/notify/fanotify/fanotify.c        |  44 ++++++---------
 fs/notify/fsnotify.c                 | 102 +++++++++++++++++++++--------------
 fs/notify/inotify/inotify.h          |   2 +-
 fs/notify/inotify/inotify_fsnotify.c |   4 +-
 fs/notify/inotify/inotify_user.c     |   2 +-
 include/linux/fsnotify_backend.h     |  20 ++++++-
 kernel/audit_fsnotify.c              |   2 +-
 kernel/audit_tree.c                  |   2 +-
 kernel/audit_watch.c                 |   2 +-
 10 files changed, 103 insertions(+), 81 deletions(-)

-- 
2.7.4