From: Amir Goldstein <amir73il@gmail.com>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Jan Kara <jack@suse.com>, Al Viro <viro@zeniv.linux.org.uk>,
linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [RFC][PATCH v2 1/3] vfs: freeze protect overlay inode on file_start_write()
Date: Mon, 23 Jan 2017 14:32:20 +0200 [thread overview]
Message-ID: <1485174742-15866-2-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1485174742-15866-1-git-send-email-amir73il@gmail.com>
Before writing to overlay file, need to check if either overlay
or upper fs are frozen.
This allows freezing overlayfs mount independently of freezing
underlying fs.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
include/linux/fs.h | 17 ++++++++++++++++-
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/include/linux/fs.h b/include/linux/fs.h
index 4a7f3cc..71811be 100644
--- a/include/linux/fs.h
+++ b/include/linux/fs.h
@@ -2547,14 +2547,26 @@ static inline void file_start_write(struct file *file)
{
if (!S_ISREG(file_inode(file)->i_mode))
return;
+ __sb_start_write(locks_inode(file)->i_sb, SB_FREEZE_WRITE, true);
+ if (likely(locks_inode(file) == file_inode(file)))
+ return;
__sb_start_write(file_inode(file)->i_sb, SB_FREEZE_WRITE, true);
+
}
static inline bool file_start_write_trylock(struct file *file)
{
+ int ret;
+
if (!S_ISREG(file_inode(file)->i_mode))
return true;
- return __sb_start_write(file_inode(file)->i_sb, SB_FREEZE_WRITE, false);
+ ret = __sb_start_write(locks_inode(file)->i_sb, SB_FREEZE_WRITE, false);
+ if (!ret || likely(locks_inode(file) == file_inode(file)))
+ return ret;
+ ret = __sb_start_write(file_inode(file)->i_sb, SB_FREEZE_WRITE, false);
+ if (!ret)
+ __sb_end_write(locks_inode(file)->i_sb, SB_FREEZE_WRITE);
+ return ret;
}
static inline void file_end_write(struct file *file)
@@ -2562,6 +2574,9 @@ static inline void file_end_write(struct file *file)
if (!S_ISREG(file_inode(file)->i_mode))
return;
__sb_end_write(file_inode(file)->i_sb, SB_FREEZE_WRITE);
+ if (likely(locks_inode(file) == file_inode(file)))
+ return;
+ __sb_end_write(locks_inode(file)->i_sb, SB_FREEZE_WRITE);
}
/*
--
2.7.4
next prev parent reply other threads:[~2017-01-23 12:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:32 [RFC][PATCH v2 0/3] overlayfs: support freeze/thaw/syncfs Amir Goldstein
2017-01-23 12:32 ` Amir Goldstein [this message]
2017-01-23 19:43 ` [RFC][PATCH v2 4/4] vfs: wrap write f_ops with file_{start,end}_write() Amir Goldstein
2017-01-24 10:09 ` Jan Kara
2017-01-27 11:09 ` Miklos Szeredi
2017-01-27 11:50 ` Amir Goldstein
2017-01-27 16:20 ` Amir Goldstein
2017-01-27 16:31 ` Darrick J. Wong
2017-01-27 17:29 ` Amir Goldstein
2017-01-27 17:51 ` Christoph Hellwig
2017-01-27 19:30 ` Michael Kerrisk (man-pages)
2017-01-27 20:09 ` Amir Goldstein
2017-01-31 7:11 ` Amir Goldstein
2017-02-06 14:49 ` Amir Goldstein
2017-02-07 15:03 ` Miklos Szeredi
2017-01-23 12:32 ` [RFC][PATCH v2 2/3] ovl: properly implement sync_filesystem() Amir Goldstein
2017-01-23 12:32 ` [RFC][PATCH v2 3/3] ovl: support freeze/thaw super Amir Goldstein
2017-01-23 19:52 ` [RFC][PATCH v2 0/3] overlayfs: support freeze/thaw/syncfs Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1485174742-15866-2-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=jack@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).