From: Martin Brandenburg <martin@omnibond.com>
To: hubcap@omnibond.com, linux-fsdevel@vger.kernel.org
Cc: Martin Brandenburg <martin@omnibond.com>
Subject: [PATCH v2 0/2] orangefs: implement statx
Date: Wed, 29 Mar 2017 11:41:11 -0400 [thread overview]
Message-ID: <1490802073-7414-1-git-send-email-martin@omnibond.com> (raw)
In-Reply-To: <1490730587-12661-1-git-send-email-martin@omnibond.com>
The last version had a problem with xfstests generic/130, generic/169,
generic/246, generic/309, and generic/393.
Other code, namely orangefs_setattr_size (truncate), looks at i_size
without knowledge that it was never set. This doesn't make decisions
whether to actually do the truncate based on the possibly not set (or
stale!) i_size.
I'm still not entirely happy with it though. I feel like we may be
missing other code which looks at i_size.
Martin Brandenburg (2):
orangefs: implement statx
orangefs: do not check possibly stale size on truncate
fs/orangefs/file.c | 6 +++--
fs/orangefs/inode.c | 18 ++++++++-----
fs/orangefs/namei.c | 3 +++
fs/orangefs/orangefs-kernel.h | 4 ++-
fs/orangefs/orangefs-utils.c | 63 +++++++++++++++++++++++++++++--------------
5 files changed, 64 insertions(+), 30 deletions(-)
--
2.1.4
next prev parent reply other threads:[~2017-03-29 15:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-28 19:49 [PATCH] orangefs: implement statx Martin Brandenburg
2017-03-29 15:41 ` Martin Brandenburg [this message]
2017-03-29 15:41 ` [PATCH v2 1/2] " Martin Brandenburg
2017-03-29 15:41 ` [PATCH v2 2/2] orangefs: do not check possibly stale size on truncate Martin Brandenburg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490802073-7414-1-git-send-email-martin@omnibond.com \
--to=martin@omnibond.com \
--cc=hubcap@omnibond.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).