From: Jeff Layton <jlayton@redhat.com>
To: Benjamin Coddington <bcodding@redhat.com>,
Trond Myklebust <trond.myklebust@primarydata.com>,
Anna Schumaker <anna.schumaker@netapp.com>,
bfields@fieldses.org, Miklos Szeredi <miklos@szeredi.hu>,
Alexander Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/6] NFS4: remove a redundant lock range check
Date: Sat, 01 Apr 2017 09:47:56 -0400 [thread overview]
Message-ID: <1491054476.18117.1.camel@redhat.com> (raw)
In-Reply-To: <65bfbbf71119f151f320d47f2e5fe423eb640e78.1491015671.git.bcodding@redhat.com>
On Fri, 2017-03-31 at 23:15 -0400, Benjamin Coddington wrote:
> flock64_to_posix_lock() is already doing this check
>
> Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> Reviewed-by: Jeff Layton <jeff.layton@primarydata.com>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> ---
> fs/nfs/nfs4proc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 0a0eaecf9676..9388899e4050 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -6570,9 +6570,6 @@ nfs4_proc_lock(struct file *filp, int cmd, struct file_lock *request)
> ctx = nfs_file_open_context(filp);
> state = ctx->state;
>
> - if (request->fl_start < 0 || request->fl_end < 0)
> - return -EINVAL;
> -
> if (IS_GETLK(cmd)) {
> if (state != NULL)
> return nfs4_proc_getlk(state, F_GETLK, request);
Reviewed-by: Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2017-04-01 13:48 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-01 3:15 [PATCH v4 0/6] Skipped unlocks Benjamin Coddington
2017-04-01 3:15 ` [PATCH 1/6] NFS4: remove a redundant lock range check Benjamin Coddington
2017-04-01 13:47 ` Jeff Layton [this message]
2017-04-01 3:15 ` [PATCH 2/6] NFS: Move the flock open mode check into nfs_flock() Benjamin Coddington
2017-04-01 13:48 ` Jeff Layton
2017-04-01 3:16 ` [PATCH 3/6] locks: Set FL_CLOSE when removing flock locks on close() Benjamin Coddington
2017-04-01 13:50 ` Jeff Layton
2017-04-03 9:44 ` Benjamin Coddington
2017-04-01 3:16 ` [PATCH 4/6] NFS: Add an iocounter wait function for async RPC tasks Benjamin Coddington
2017-04-02 14:29 ` kbuild test robot
2017-04-03 9:42 ` Benjamin Coddington
2017-04-01 3:16 ` [PATCH 5/6] lockd: Introduce nlmclnt_operations Benjamin Coddington
2017-04-01 14:05 ` Jeff Layton
2017-04-03 9:40 ` Benjamin Coddington
2017-04-06 11:19 ` Benjamin Coddington
2017-04-01 3:16 ` [PATCH 6/6] NFS: Always wait for I/O completion before unlock Benjamin Coddington
-- strict thread matches above, loose matches on Subject: below --
2017-04-06 11:23 [PATCH v5 0/6] Skipped unlocks Benjamin Coddington
2017-04-06 11:23 ` [PATCH 1/6] NFS4: remove a redundant lock range check Benjamin Coddington
2017-04-11 16:50 [PATCH v6 0/6] Skipped unlocks Benjamin Coddington
2017-04-11 16:50 ` [PATCH 1/6] NFS4: remove a redundant lock range check Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1491054476.18117.1.camel@redhat.com \
--to=jlayton@redhat.com \
--cc=anna.schumaker@netapp.com \
--cc=bcodding@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=trond.myklebust@primarydata.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).