From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mga07.intel.com ([134.134.136.100]:33095 "EHLO mga07.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1750786AbdEDI0C (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 4 May 2017 04:26:02 -0400
Message-ID: <1493886085.30052.14.camel@linux.intel.com>
Subject: Re: [RFC][PATCH] linux/uuid.h: hoist uuid_is_null() helper from
 libnvdimm
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Amir Goldstein <amir73il@gmail.com>
Cc: Christoph Hellwig <hch@lst.de>, Miklos Szeredi <miklos@szeredi.hu>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
        Richard Weinberger <richard@nod.at>,
        "Darrick J . Wong" <darrick.wong@oracle.com>,
        Mark Fasheh <mfasheh@versity.com>,
        Al Viro <viro@zeniv.linux.org.uk>,
        linux-xfs <linux-xfs@vger.kernel.org>,
        linux-unionfs@vger.kernel.org,
        linux-fsdevel <linux-fsdevel@vger.kernel.org>,
        Dan Williams <dan.j.williams@intel.com>,
        David Howells <dhowells@redhat.com>,
        Theodore Tso <tytso@mit.edu>
Date: Thu, 04 May 2017 11:21:25 +0300
In-Reply-To: <CAOQ4uxg6=X8GVfWBBYwYLHyNcx7E856kEFM339abLsVEbWzi_Q@mail.gmail.com>
References: <1493756363-5113-1-git-send-email-amir73il@gmail.com>
         <1493802823.4154.3.camel@linux.intel.com>
         <CAOQ4uxh4Ysg9Q_K2sK9zefvid3hvzswDKxSa-QTN9_D0fAWvyQ@mail.gmail.com>
         <1493809233.30052.1.camel@linux.intel.com>
         <CAOQ4uxj3ppxm4LC6xr54n6GUF1T=yhQ4-5YJfbjXcBJugVENZQ@mail.gmail.com>
         <1493829352.30052.6.camel@linux.intel.com>
         <1493831747.30052.10.camel@linux.intel.com>
         <CAOQ4uxg6=X8GVfWBBYwYLHyNcx7E856kEFM339abLsVEbWzi_Q@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Wed, 2017-05-03 at 21:34 +0300, Amir Goldstein wrote:
> On Wed, May 3, 2017 at 8:15 PM, Andy Shevchenko
> <andriy.shevchenko@linux.intel.com> wrote:
> 
> > 
> > By the way, notice that uuid_v1 type (which had been moved to uuid.h
> > already) is the same what xfs uses as uuid_t.
> > 
> > So, helpers against it we can prefix with uuid_v1_[foo_bar()].
> > 
> 
> I really don't see why we can't use the exact same helpers
> found in fs/xfs/uuid.c and uuid_t as well for that matter.

Does it make sense to have two types that defines the same?

> They are mostly similar to the libuuid API that filesystems
> tools use in userspace and they don't collide with your
> uuid_{le|be} helpers.

Okay, if you are insisting just move them to the header, we may simplify
it later, though I think that there is no makes sense to do any effort
that will be neglected in the future (so, just movement is fine, but
using it elsewhere I prefer to have 1 type and const for parameters).

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy