From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f173.google.com ([209.85.220.173]:34216 "EHLO mail-qk0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbdE3K0m (ORCPT ); Tue, 30 May 2017 06:26:42 -0400 Received: by mail-qk0-f173.google.com with SMTP id d14so24650395qkb.1 for ; Tue, 30 May 2017 03:26:42 -0700 (PDT) Message-ID: <1496139999.2811.1.camel@redhat.com> Subject: Re: [PATCH] fuse: set mapping error in writepage_locked when it fails From: Jeff Layton To: Miklos Szeredi Cc: linux-fsdevel@vger.kernel.org, Christoph Hellwig , Jan Kara Date: Tue, 30 May 2017 06:26:39 -0400 In-Reply-To: References: <20170525105750.8663-1-jlayton@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2017-05-29 at 15:04 +0200, Miklos Szeredi wrote: > On Thu, May 25, 2017 at 12:57 PM, Jeff Layton wrote: > > This ensures that we see errors on fsync when writeback fails. > > > > Signed-off-by: Jeff Layton > > Reviewed-by: Christoph Hellwig > > Reviewed-by: Jan Kara > > This is currently the only fuse patch for 4.12. Do you plan to send a > pull to Linus with related things? If so then please feel free to > take this and add my > > Acked-by: Miklos Szeredi > No, I wasn't planning to send a PR to Linus. I was really expecting these to go into v4.13 anyway (and maybe linux- next for now). I don't think it'll hurt to merge them into v4.12 though if you end up with other FUSE patches for v4.12 and want to merge it earlier. > > --- > > fs/fuse/file.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/fs/fuse/file.c b/fs/fuse/file.c > > index 3ee4fdc3da9e..18518298d109 100644 > > --- a/fs/fuse/file.c > > +++ b/fs/fuse/file.c > > @@ -1669,6 +1669,7 @@ static int fuse_writepage_locked(struct page *page) > > err_free: > > fuse_request_free(req); > > err: > > + mapping_set_error(page->mapping, error); > > end_page_writeback(page); > > return error; > > } > > -- > > 2.9.4 > > Thanks, -- Jeff Layton