From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1497349642.5762.3.camel@redhat.com> Subject: Re: [PATCH v6 19/20] xfs: minimal conversion to errseq_t writeback error reporting From: Jeff Layton To: "Darrick J. Wong" Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Date: Tue, 13 Jun 2017 06:27:22 -0400 In-Reply-To: <20170613043056.GO4530@birch.djwong.org> References: <20170612122316.13244-1-jlayton@redhat.com> <20170612122316.13244-24-jlayton@redhat.com> <20170613043056.GO4530@birch.djwong.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On Mon, 2017-06-12 at 21:30 -0700, Darrick J. Wong wrote: > On Mon, Jun 12, 2017 at 08:23:15AM -0400, Jeff Layton wrote: > > Just set the FS_WB_ERRSEQ flag to indicate that we want to use errseq_t > > based error reporting. Internal filemap_* calls are left as-is for now. > > > > Signed-off-by: Jeff Layton > > --- > > fs/xfs/xfs_super.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > > index 455a575f101d..28d3be187025 100644 > > --- a/fs/xfs/xfs_super.c > > +++ b/fs/xfs/xfs_super.c > > @@ -1758,7 +1758,7 @@ static struct file_system_type xfs_fs_type = { > > .name = "xfs", > > .mount = xfs_fs_mount, > > .kill_sb = kill_block_super, > > - .fs_flags = FS_REQUIRES_DEV, > > + .fs_flags = FS_REQUIRES_DEV | FS_WB_ERRSEQ, > > Huh? Why are there two patches with the same subject line? And this > same bit of code too? Or ... 11/13, 11/20? What's going on here? > > > > --D Oh my -- sorry about that. I ended up with two different interleaved patchsets. The /20 series is the one I meant to send. Just ignore these for now though, as I'll be sending a v7 (at least) to address HCH's comments. -- Jeff Layton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org