From: Jens Axboe <axboe@kernel.dk>
To: linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org
Cc: adilger@dilger.ca, Jens Axboe <axboe@kernel.dk>
Subject: [PATCH 01/10] block: add support for carrying stream information in a bio
Date: Tue, 13 Jun 2017 22:01:50 -0600 [thread overview]
Message-ID: <1497412919-19400-2-git-send-email-axboe@kernel.dk> (raw)
In-Reply-To: <1497412919-19400-1-git-send-email-axboe@kernel.dk>
No functional changes in this patch, but it allows each bio to
carry a stream ID and disallows merging of bio's with different
stream IDs.
Signed-off-by: Jens Axboe <axboe@kernel.dk>
---
block/bio.c | 2 ++
block/blk-merge.c | 14 ++++++++++++++
include/linux/blk_types.h | 17 +++++++++++++++++
3 files changed, 33 insertions(+)
diff --git a/block/bio.c b/block/bio.c
index 888e7801c638..77f4be1f7428 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -595,6 +595,7 @@ void __bio_clone_fast(struct bio *bio, struct bio *bio_src)
bio->bi_opf = bio_src->bi_opf;
bio->bi_iter = bio_src->bi_iter;
bio->bi_io_vec = bio_src->bi_io_vec;
+ bio->bi_stream = bio_src->bi_stream;
bio_clone_blkcg_association(bio, bio_src);
}
@@ -678,6 +679,7 @@ struct bio *bio_clone_bioset(struct bio *bio_src, gfp_t gfp_mask,
bio->bi_opf = bio_src->bi_opf;
bio->bi_iter.bi_sector = bio_src->bi_iter.bi_sector;
bio->bi_iter.bi_size = bio_src->bi_iter.bi_size;
+ bio->bi_stream = bio_src->bi_stream;
switch (bio_op(bio)) {
case REQ_OP_DISCARD:
diff --git a/block/blk-merge.c b/block/blk-merge.c
index 3990ae406341..28998acdd675 100644
--- a/block/blk-merge.c
+++ b/block/blk-merge.c
@@ -693,6 +693,13 @@ static struct request *attempt_merge(struct request_queue *q,
return NULL;
/*
+ * Don't allow merge of different streams, or for a stream with
+ * non-stream IO.
+ */
+ if (req->bio->bi_stream != next->bio->bi_stream)
+ return NULL;
+
+ /*
* If we are allowed to merge, then append bio list
* from next to rq and release next. merge_requests_fn
* will have updated segment counts, update sector
@@ -811,6 +818,13 @@ bool blk_rq_merge_ok(struct request *rq, struct bio *bio)
!blk_write_same_mergeable(rq->bio, bio))
return false;
+ /*
+ * Don't allow merge of different streams, or for a stream with
+ * non-stream IO.
+ */
+ if (rq->bio->bi_stream != bio->bi_stream)
+ return false;
+
return true;
}
diff --git a/include/linux/blk_types.h b/include/linux/blk_types.h
index 61339bc44400..1940876a7fa7 100644
--- a/include/linux/blk_types.h
+++ b/include/linux/blk_types.h
@@ -36,6 +36,8 @@ struct bio {
unsigned short bi_flags; /* status, etc and bvec pool number */
unsigned short bi_ioprio;
+ unsigned int bi_stream; /* write life time hint */
+
struct bvec_iter bi_iter;
/* Number of segments in this BIO after
@@ -312,4 +314,19 @@ struct blk_rq_stat {
u64 batch;
};
+static inline void bio_set_streamid(struct bio *bio, unsigned int stream)
+{
+ bio->bi_stream = stream;
+}
+
+static inline bool bio_stream_valid(struct bio *bio)
+{
+ return bio->bi_stream != 0;
+}
+
+static inline unsigned int bio_stream(struct bio *bio)
+{
+ return bio->bi_stream;
+}
+
#endif /* __LINUX_BLK_TYPES_H */
--
2.7.4
next prev parent reply other threads:[~2017-06-14 4:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 4:01 [PATCHSET v2] Add support for write life time hints Jens Axboe
2017-06-14 4:01 ` Jens Axboe [this message]
2017-06-14 4:01 ` [PATCH 02/10] blk-mq: expose stream write stats through debugfs Jens Axboe
2017-06-14 4:07 ` Andreas Dilger
2017-06-14 4:01 ` [PATCH 03/10] fs: add support for an inode to carry stream related data Jens Axboe
2017-06-14 4:01 ` [PATCH 04/10] fs: add support for allowing applications to pass in write life time hints Jens Axboe
2017-06-14 4:06 ` Andreas Dilger
2017-06-14 4:01 ` [PATCH 05/10] fs: add O_DIRECT support for sending down bio stream information Jens Axboe
2017-06-14 4:01 ` [PATCH 06/10] fs: add support for buffered writeback to pass down " Jens Axboe
2017-06-14 4:01 ` [PATCH 07/10] ext4: add support for passing in stream information for buffered writes Jens Axboe
2017-06-14 4:01 ` [PATCH 08/10] xfs: " Jens Axboe
2017-06-14 4:01 ` [PATCH 09/10] btrfs: " Jens Axboe
2017-06-14 4:01 ` [PATCH 10/10] nvme: add support for streams and directives Jens Axboe
2017-06-14 4:10 ` Andreas Dilger
2017-06-14 15:45 ` [PATCHSET v2] Add support for write life time hints Martin K. Petersen
2017-06-14 15:53 ` Jens Axboe
2017-06-14 16:00 ` Martin K. Petersen
2017-06-14 16:03 ` Jens Axboe
2017-06-14 16:01 ` Christoph Hellwig
2017-06-14 16:02 ` Jens Axboe
2017-06-14 16:04 ` Martin K. Petersen
2017-06-14 16:26 ` Jens Axboe
2017-06-14 17:22 ` Jens Axboe
2017-06-14 23:39 ` Andreas Dilger
2017-06-15 3:26 ` Jens Axboe
2017-06-15 3:53 ` Andreas Dilger
2017-06-15 3:57 ` Jens Axboe
2017-06-15 4:38 ` Jens Axboe
2017-06-16 13:58 ` Christoph Hellwig
2017-06-16 14:40 ` Jens Axboe
2017-06-16 15:52 ` Christoph Hellwig
2017-06-16 15:55 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1497412919-19400-2-git-send-email-axboe@kernel.dk \
--to=axboe@kernel.dk \
--cc=adilger@dilger.ca \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).