From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1497539004.4607.7.camel@redhat.com> Subject: Re: [PATCH v6 12/20] fs: add a new fstype flag to indicate how writeback errors are tracked From: Jeff Layton To: Christoph Hellwig Cc: Andrew Morton , Al Viro , Jan Kara , tytso@mit.edu, axboe@kernel.dk, mawilcox@microsoft.com, ross.zwisler@linux.intel.com, corbet@lwn.net, Chris Mason , Josef Bacik , David Sterba , "Darrick J . Wong" , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org Date: Thu, 15 Jun 2017 11:03:24 -0400 In-Reply-To: <20170615145724.GB14028@infradead.org> References: <20170612122316.13244-1-jlayton@redhat.com> <20170612122316.13244-15-jlayton@redhat.com> <20170612124513.GC18360@infradead.org> <1497349472.5762.1.camel@redhat.com> <20170614064731.GB3598@infradead.org> <1497461083.6752.7.camel@redhat.com> <20170615082221.GA22809@infradead.org> <1497523332.4556.1.camel@redhat.com> <20170615145724.GB14028@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: owner-linux-mm@kvack.org List-ID: On Thu, 2017-06-15 at 07:57 -0700, Christoph Hellwig wrote: > On Thu, Jun 15, 2017 at 06:42:12AM -0400, Jeff Layton wrote: > > Correct. > > > > But if there is a data writeback error, should we report an error on all > > open fds at that time (like we will for fsync)? > > We should in theory, but I don't see how to properly do it. In addition > sync_file_range just can't be used for data integrity to start with, so > I don't think it's worth it. At some point we should add a proper > fsync_range syscall, though. filemap_report_wb_err will always return 0 if the inode never has mapping_set_error called on it. So, I think we should be able to do it there once we get all of the fs' converted over. That'll have to happen at the end of the series however. -- Jeff Layton -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org