linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Geert Uytterhoeven <geert@linux-m68k.org>
To: Alexander Viro <viro@zeniv.linux.org.uk>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Steven Miao <realmz6@gmail.com>,
	Yoshinori Sato <ysato@users.sourceforge.jp>,
	Greg Ungerer <gerg@linux-m68k.org>,
	adi-buildroot-devel@lists.sourceforge.net,
	uclinux-h8-devel@lists.sourceforge.jp,
	linux-m68k@lists.linux-m68k.org, linux-fsdevel@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Geert Uytterhoeven <geert@linux-m68k.org>
Subject: [PATCH 3/3] h8300: Add missing closing parenthesis in flat_get_addr_from_rp()
Date: Sun, 16 Jul 2017 13:57:29 +0200	[thread overview]
Message-ID: <1500206249-16670-3-git-send-email-geert@linux-m68k.org> (raw)
In-Reply-To: <1500206249-16670-1-git-send-email-geert@linux-m68k.org>

In file included from include/linux/flat.h:13:0,
                 from fs/binfmt_flat.c:36:
arch/h8300/include/asm/flat.h: In function 'flat_get_addr_from_rp':
arch/h8300/include/asm/flat.h:28:3: error: expected ')' before 'val'
   val &= 0x00ffffff;
   ^
arch/h8300/include/asm/flat.h:31:1: error: expected expression before '}' token
 }
 ^
In file included from include/linux/flat.h:13:0,
                 from fs/binfmt_flat.c:36:
arch/h8300/include/asm/flat.h:26:6: warning: unused variable 'val' [-Wunused-variable]
  u32 val = get_unaligned((__force u32 *)rp);
      ^
In file included from include/linux/flat.h:13:0,
                 from fs/binfmt_flat.c:36:
arch/h8300/include/asm/flat.h:31:1: warning: no return statement in function returning non-void [-Wreturn-type]
 }
 ^

Reported-by: kbuild test robot <fengguang.wu@intel.com>
Fixes: 468138d78510688f ("binfmt_flat: flat_{get,put}_addr_from_rp() should be able to fail")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
 arch/h8300/include/asm/flat.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/h8300/include/asm/flat.h b/arch/h8300/include/asm/flat.h
index 18d024251738dd4e..7e0bd6fa15324495 100644
--- a/arch/h8300/include/asm/flat.h
+++ b/arch/h8300/include/asm/flat.h
@@ -24,7 +24,7 @@ static inline int flat_get_addr_from_rp(u32 __user *rp, u32 relval, u32 flags,
 					u32 *addr, u32 *persistent)
 {
 	u32 val = get_unaligned((__force u32 *)rp);
-	if (!(flags & FLAT_FLAG_GOTPIC)
+	if (!(flags & FLAT_FLAG_GOTPIC))
 		val &= 0x00ffffff;
 	*addr = val;
 	return 0;
-- 
2.7.4

      parent reply	other threads:[~2017-07-16 11:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-16 11:57 [PATCH 1/3] binfmt_flat: Use %u to format u32 Geert Uytterhoeven
2017-07-16 11:57 ` [PATCH 2/3] blackfin, m68k: Fix flat_set_persistent() for unsigned long to u32 changes Geert Uytterhoeven
2017-07-16 11:57 ` Geert Uytterhoeven [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1500206249-16670-3-git-send-email-geert@linux-m68k.org \
    --to=geert@linux-m68k.org \
    --cc=adi-buildroot-devel@lists.sourceforge.net \
    --cc=gerg@linux-m68k.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-m68k@lists.linux-m68k.org \
    --cc=realmz6@gmail.com \
    --cc=torvalds@linux-foundation.org \
    --cc=uclinux-h8-devel@lists.sourceforge.jp \
    --cc=viro@zeniv.linux.org.uk \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).