* [PATCH] f2fs-tools: the overprovision should be 0 as default
@ 2017-08-11 13:25 Yunlong Song
2017-08-15 3:24 ` Jaegeuk Kim
2017-08-15 7:41 ` [PATCH v2] f2fs-tools: fix the usage message of overprovision option Yunlong Song
0 siblings, 2 replies; 4+ messages in thread
From: Yunlong Song @ 2017-08-11 13:25 UTC (permalink / raw)
To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
Cc: miaoxie, bintian.wang, linux-fsdevel, linux-f2fs-devel,
linux-kernel
The usage message gives a wrong number, so fix it.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
mkfs/f2fs_format_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
index a3652a9..6712b5c 100644
--- a/mkfs/f2fs_format_main.c
+++ b/mkfs/f2fs_format_main.c
@@ -41,7 +41,7 @@ static void mkfs_usage()
MSG(0, " -f force overwrite the exist filesystem\n");
MSG(0, " -l label\n");
MSG(0, " -m support zoned block device [default:0]\n");
- MSG(0, " -o overprovision ratio [default:5]\n");
+ MSG(0, " -o overprovision ratio [default:0]\n");
MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
MSG(0, " -q quiet mode\n");
MSG(0, " -s # of segments per section [default:1]\n");
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] f2fs-tools: the overprovision should be 0 as default
2017-08-11 13:25 [PATCH] f2fs-tools: the overprovision should be 0 as default Yunlong Song
@ 2017-08-15 3:24 ` Jaegeuk Kim
2017-08-15 7:41 ` [PATCH v2] f2fs-tools: fix the usage message of overprovision option Yunlong Song
1 sibling, 0 replies; 4+ messages in thread
From: Jaegeuk Kim @ 2017-08-15 3:24 UTC (permalink / raw)
To: Yunlong Song
Cc: chao, yuchao0, yunlong.song, miaoxie, bintian.wang, linux-fsdevel,
linux-f2fs-devel, linux-kernel
On 08/11, Yunlong Song wrote:
> The usage message gives a wrong number, so fix it.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> mkfs/f2fs_format_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index a3652a9..6712b5c 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -41,7 +41,7 @@ static void mkfs_usage()
> MSG(0, " -f force overwrite the exist filesystem\n");
> MSG(0, " -l label\n");
> MSG(0, " -m support zoned block device [default:0]\n");
> - MSG(0, " -o overprovision ratio [default:5]\n");
> + MSG(0, " -o overprovision ratio [default:0]\n");
We need to remove [default:xx], since the default is not fixed?
> MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
> MSG(0, " -q quiet mode\n");
> MSG(0, " -s # of segments per section [default:1]\n");
> --
> 1.8.5.2
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] f2fs-tools: fix the usage message of overprovision option
2017-08-11 13:25 [PATCH] f2fs-tools: the overprovision should be 0 as default Yunlong Song
2017-08-15 3:24 ` Jaegeuk Kim
@ 2017-08-15 7:41 ` Yunlong Song
2017-08-15 12:09 ` Chao Yu
1 sibling, 1 reply; 4+ messages in thread
From: Yunlong Song @ 2017-08-15 7:41 UTC (permalink / raw)
To: jaegeuk, chao, yuchao0, yunlong.song, yunlong.song
Cc: miaoxie, bintian.wang, linux-fsdevel, linux-f2fs-devel,
linux-kernel
The usage message shows a wrong message for ovp option, so fix it.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
---
mkfs/f2fs_format_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
index a3652a9..3279829 100644
--- a/mkfs/f2fs_format_main.c
+++ b/mkfs/f2fs_format_main.c
@@ -41,7 +41,7 @@ static void mkfs_usage()
MSG(0, " -f force overwrite the exist filesystem\n");
MSG(0, " -l label\n");
MSG(0, " -m support zoned block device [default:0]\n");
- MSG(0, " -o overprovision ratio [default:5]\n");
+ MSG(0, " -o overprovision ratio [initial value 0 lets mkfs determine its best value]\n");
MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
MSG(0, " -q quiet mode\n");
MSG(0, " -s # of segments per section [default:1]\n");
--
1.8.5.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] f2fs-tools: fix the usage message of overprovision option
2017-08-15 7:41 ` [PATCH v2] f2fs-tools: fix the usage message of overprovision option Yunlong Song
@ 2017-08-15 12:09 ` Chao Yu
0 siblings, 0 replies; 4+ messages in thread
From: Chao Yu @ 2017-08-15 12:09 UTC (permalink / raw)
To: Yunlong Song, jaegeuk, chao, yunlong.song
Cc: miaoxie, bintian.wang, linux-fsdevel, linux-f2fs-devel,
linux-kernel
On 2017/8/15 15:41, Yunlong Song wrote:
> The usage message shows a wrong message for ovp option, so fix it.
>
> Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
> ---
> mkfs/f2fs_format_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mkfs/f2fs_format_main.c b/mkfs/f2fs_format_main.c
> index a3652a9..3279829 100644
> --- a/mkfs/f2fs_format_main.c
> +++ b/mkfs/f2fs_format_main.c
> @@ -41,7 +41,7 @@ static void mkfs_usage()
> MSG(0, " -f force overwrite the exist filesystem\n");
> MSG(0, " -l label\n");
> MSG(0, " -m support zoned block device [default:0]\n");
> - MSG(0, " -o overprovision ratio [default:5]\n");
> + MSG(0, " -o overprovision ratio [initial value 0 lets mkfs determine its best value]\n");
[mkfs decides, the value trends to maximize user visible space] ?
Thanks,
> MSG(0, " -O [feature list] e.g. \"encrypt\"\n");
> MSG(0, " -q quiet mode\n");
> MSG(0, " -s # of segments per section [default:1]\n");
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-15 12:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-08-11 13:25 [PATCH] f2fs-tools: the overprovision should be 0 as default Yunlong Song
2017-08-15 3:24 ` Jaegeuk Kim
2017-08-15 7:41 ` [PATCH v2] f2fs-tools: fix the usage message of overprovision option Yunlong Song
2017-08-15 12:09 ` Chao Yu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).