From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf0-f177.google.com ([209.85.192.177]:51792 "EHLO mail-pf0-f177.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752477AbdJPPud (ORCPT ); Mon, 16 Oct 2017 11:50:33 -0400 Received: by mail-pf0-f177.google.com with SMTP id n14so16090410pfh.8 for ; Mon, 16 Oct 2017 08:50:33 -0700 (PDT) Message-ID: <1508169030.3006.24.camel@dubeyko.com> Subject: Re: [PATCH 2/2] hfsplus: add mount option to enable ACL support From: Viacheslav Dubeyko To: Christoph Hellwig , "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?= Cc: Jan Kara , linux-fsdevel@vger.kernel.org, Andreas Gruenbacher , Alexander Viro Date: Mon, 16 Oct 2017 08:50:30 -0700 In-Reply-To: <20171016074210.GA1053@infradead.org> References: <4d0758dad0ee32bda49113a957a8b5d9ce882e9b.1501124092.git.ernesto.mnd.fernandez@gmail.com> <7f2987dd3b8eace03dece289d35011ef65170c11.1501124092.git.ernesto.mnd.fernandez@gmail.com> <20170727094147.GE21100@quack2.suse.cz> <20170727095053.GA8136@infradead.org> <20171014024318.GA8995@debian.home> <20171016074210.GA1053@infradead.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2017-10-16 at 00:42 -0700, Christoph Hellwig wrote: > On Fri, Oct 13, 2017 at 11:43:19PM -0300, Ernesto A. Fernández wrote: > > > > Since there was no more discussion I suppose I should go ahead and > > do it. I'm using your rationale in the commit message, let me know > > if > > either of you wants to be tagged as "Suggested-by", or in any other > > way. Thank you. > I don't think I suggested it, but I'd be happy to ACK it: > I believe that it's not right way of doing things. The exclsuion of this section of code doesn't mean that HFS+ file system driver will not have any bugs. If we follow this logic then it makes sense to exclude the whole HFS+ support from the Linux kernel especcially if nobody cares about HFS+ support anymore. Thanks, Vyacheslav Dubeyko.