From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f193.google.com ([209.85.220.193]:55690 "EHLO mail-qk0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932230AbdJ3PDd (ORCPT ); Mon, 30 Oct 2017 11:03:33 -0400 Received: by mail-qk0-f193.google.com with SMTP id x82so16470421qkb.12 for ; Mon, 30 Oct 2017 08:03:33 -0700 (PDT) Message-ID: <1509375810.5412.22.camel@poochiereds.net> Subject: Re: [PATCH] ecryptfs: remove unnecessary i_version bump From: Jeff Layton To: tyhicks@canonical.com Cc: ecryptfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Date: Mon, 30 Oct 2017 11:03:30 -0400 In-Reply-To: <20171030150131.2587-1-jlayton@kernel.org> References: <20171030150131.2587-1-jlayton@kernel.org> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, 2017-10-30 at 11:01 -0400, Jeff Layton wrote: > From: Jeff Layton > > There is no need to bump the i_version counter here, as ecryptfs does > not set the MS_I_VERSION flag, and doesn't use it internally. It also My apologies, I've been sitting on this patch for a while now. That should be changed to the SB_I_VERSION flag. Tyler, do you mind fixing that up before merge, or would you like me to resend? > only bumps it when the inode is instantiated, which doesn't make much > sense. > > Signed-off-by: Jeff Layton > --- > fs/ecryptfs/inode.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/ecryptfs/inode.c b/fs/ecryptfs/inode.c > index efc2db42d175..b59b083379ea 100644 > --- a/fs/ecryptfs/inode.c > +++ b/fs/ecryptfs/inode.c > @@ -64,7 +64,6 @@ static int ecryptfs_inode_set(struct inode *inode, void *opaque) > /* i_size will be overwritten for encrypted regular files */ > fsstack_copy_inode_size(inode, lower_inode); > inode->i_ino = lower_inode->i_ino; > - inode->i_version++; > inode->i_mapping->a_ops = &ecryptfs_aops; > > if (S_ISLNK(inode->i_mode)) -- Jeff Layton