From: Salvatore Mesoraca <s.mesoraca16@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Kernel Hardening <kernel-hardening@lists.openwall.com>,
linux-fsdevel@vger.kernel.org,
Salvatore Mesoraca <s.mesoraca16@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
Jann Horn <jannh@google.com>, Kees Cook <keescook@chromium.org>,
Solar Designer <solar@openwall.com>,
"Eric W. Biederman" <ebiederm@xmission.com>
Subject: [PATCH v3 0/2] Restrict dangerous open in sticky directories
Date: Wed, 22 Nov 2017 09:01:44 +0100 [thread overview]
Message-ID: <1511337706-8297-1-git-send-email-s.mesoraca16@gmail.com> (raw)
This patch-set introduces two separate features aimed at restricting
dangerous open in world or group writable sticky directories.
The purpose is to prevent exploitable bugs in user-space programs
that don't access sticky directories in the proper way.
The first patch prevents the O_CREAT open of FIFOs and regular files
in world or group writable sticky directories, if they already exists
and are owned by someone else.
The second patch prevents O_CREAT open in world or group writable
sticky when the O_EXCL flag is not set, even if the file doesn't
exist yet.
More details can be found in the respective commit messages.
Changes in v3:
- Fixed format string for uid_t that is unsigned
(suggested by Jann Horn).
- Stop checking if file's and parent dir's owners match in
may_create_no_excl. This will allow to discover potential
vulnerabilities more easily.
Salvatore Mesoraca (2):
Protected FIFOs and regular files
Protected O_CREAT open in sticky directories
Documentation/sysctl/fs.txt | 66 +++++++++++++++++++++++++
fs/namei.c | 117 ++++++++++++++++++++++++++++++++++++++++++--
include/linux/fs.h | 3 ++
kernel/sysctl.c | 27 ++++++++++
4 files changed, 210 insertions(+), 3 deletions(-)
--
1.9.1
next reply other threads:[~2017-11-22 8:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 8:01 Salvatore Mesoraca [this message]
2017-11-22 8:01 ` [PATCH v3 1/2] Protected FIFOs and regular files Salvatore Mesoraca
2017-11-23 22:43 ` [kernel-hardening] " Tobin C. Harding
2017-11-24 8:24 ` Salvatore Mesoraca
2017-11-22 8:01 ` [PATCH v3 2/2] Protected O_CREAT open in sticky directories Salvatore Mesoraca
2017-11-22 13:22 ` Matthew Wilcox
2017-11-24 8:29 ` Salvatore Mesoraca
2017-11-22 16:51 ` Alan Cox
2017-11-24 8:31 ` Salvatore Mesoraca
2017-11-24 10:53 ` David Laight
2017-11-24 11:43 ` Salvatore Mesoraca
2017-11-24 11:53 ` David Laight
2017-11-26 11:29 ` Salvatore Mesoraca
2017-11-27 0:26 ` Solar Designer
2017-11-30 14:39 ` Salvatore Mesoraca
2017-11-30 14:57 ` [kernel-hardening] " Ian Campbell
2017-11-30 16:30 ` [kernel-hardening] " Solar Designer
2017-12-05 10:21 ` Salvatore Mesoraca
2017-12-07 21:47 ` Solar Designer
2017-12-11 12:08 ` Salvatore Mesoraca
2017-11-23 22:57 ` Tobin C. Harding
2017-11-24 8:34 ` Salvatore Mesoraca
2017-11-30 16:53 ` David Laight
2017-11-30 17:51 ` Solar Designer
2017-12-01 9:46 ` David Laight
2017-12-01 15:52 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511337706-8297-1-git-send-email-s.mesoraca16@gmail.com \
--to=s.mesoraca16@gmail.com \
--cc=ebiederm@xmission.com \
--cc=jannh@google.com \
--cc=keescook@chromium.org \
--cc=kernel-hardening@lists.openwall.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=solar@openwall.com \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).