From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl0-f44.google.com ([209.85.160.44]:35398 "EHLO mail-pl0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753217AbdK1Ru1 (ORCPT ); Tue, 28 Nov 2017 12:50:27 -0500 Received: by mail-pl0-f44.google.com with SMTP id b96so365662pli.2 for ; Tue, 28 Nov 2017 09:50:27 -0800 (PST) Message-ID: <1511891425.2822.10.camel@dubeyko.com> Subject: Re: [PATCH] hfsplus: fix decomposition of Hangul characters From: Viacheslav Dubeyko To: Hin-Tak Leung , "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?= Cc: linux-fsdevel@vger.kernel.org, tchou , Alexander Viro , Andrew Morton Date: Tue, 28 Nov 2017 09:50:25 -0800 In-Reply-To: <1999104027.7153972.1511885718712@mail.yahoo.com> References: <1999104027.7153972.1511885718712.ref@mail.yahoo.com> <1999104027.7153972.1511885718712@mail.yahoo.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Tue, 2017-11-28 at 16:15 +0000, Hin-Tak Leung wrote: > -------------------------------------------- > On Tue, 28/11/17, Ernesto A. Fernández om> wrote: > > > > > The algorithm is very simple, the best way to > > understand it is just > > looking at the code. I > > don't know the first thing about Korean writing, so > > I don't think I should attempt to explain > > why the decomposition is done > > this way. If > > somebody else is interested in the details, they can > > follow > > the citation in the header comment of > > the decompose_hangul function. >   > Apologies for coming into this a bit late. > > A couple of points: > > 1. Hangul canonical composition and decomposition is a separate topic > from compositions of latin characters with accents. It is described > in  > >  http://www.unicode.org/reports/tr15/tr15-18.html#Hangul > > among other sources. > > 2. I think the mount option is a bit of a red-herring. I think we > should just do what Mac OS X does - I think in the tech note it says > something about storing things always in the decomposed form or > composed form. Ideally we should make the differing mount options no- > ops. Mac OS X does not need extra mount options, we shouldn't either. Do you mean the using of textEncoding field in the Volume Header or/and textEncoding in the Ctalog Folder's records? But I am not completelely sure what flag can be Hangul related. Do you have any hints? Thanks, Vyacheslav Dubeyko.