From: Vasyl Gomonovych <gomonovych@gmail.com>
To: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
gomonovych@gmail.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR'
Date: Fri, 8 Dec 2017 00:03:07 +0100 [thread overview]
Message-ID: <1512687788-27172-1-git-send-email-gomonovych@gmail.com> (raw)
p could be NULL and passing into PTR_ERR
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
fs/seq_file.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/fs/seq_file.c b/fs/seq_file.c
index 4be761c..8b700b9 100644
--- a/fs/seq_file.c
+++ b/fs/seq_file.c
@@ -262,8 +262,8 @@ ssize_t seq_read(struct file *file, char __user *buf, size_t size, loff_t *ppos)
size_t offs = m->count;
loff_t next = pos;
p = m->op->next(m, p, &next);
- if (!p || IS_ERR(p)) {
- err = PTR_ERR(p);
+ if (IS_ERR(p)) {
+ err = (!p ? -EFAULT : PTR_ERR(p));
break;
}
err = m->op->show(m, p);
--
1.9.1
next reply other threads:[~2017-12-07 23:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-07 23:03 Vasyl Gomonovych [this message]
2017-12-07 23:20 ` [PATCH] fs/seq_file: Fix warning of passing zero to 'PTR_ERR' Matthew Wilcox
2017-12-07 23:23 ` Al Viro
2017-12-07 23:26 ` Al Viro
2017-12-08 7:54 ` Gomonovych, Vasyl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512687788-27172-1-git-send-email-gomonovych@gmail.com \
--to=gomonovych@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).