From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr0-f195.google.com ([209.85.128.195]:35418 "EHLO mail-wr0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752445AbeABM0D (ORCPT ); Tue, 2 Jan 2018 07:26:03 -0500 From: Amir Goldstein To: Jeff Layton , "J . Bruce Fields" Cc: Miklos Szeredi , linux-unionfs@vger.kernel.org, linux-fsdevel@vger.kernel.org Subject: [RFC][PATCH 1/2] vfs: update overlay inode times on write Date: Tue, 2 Jan 2018 14:26:48 +0200 Message-Id: <1514896009-11468-2-git-send-email-amir73il@gmail.com> In-Reply-To: <1514896009-11468-1-git-send-email-amir73il@gmail.com> References: <1514896009-11468-1-git-send-email-amir73il@gmail.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Currently with overlayfs, the real upper inode's i_mtime is updated on write, but not overlay vfs inode. The vfs inode's i_mtime is used by nfsd to check if nfs client cache is stale, so updating the overlay vfs inode i_mtime on write is required for overlayfs NFS export support. The non uptodate mtime issue was found and verified with the nfstest_posix test when run over NFS exported overlayfs: $ nfstest_posix --runtest=write ... FAIL: write - file st_mtime should be updated Signed-off-by: Amir Goldstein --- fs/inode.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/fs/inode.c b/fs/inode.c index 03102d6ef044..a252256f4e51 100644 --- a/fs/inode.c +++ b/fs/inode.c @@ -1567,8 +1567,7 @@ EXPORT_SYMBOL(bmap); /* * Update times in overlayed inode from underlying real inode */ -static void update_ovl_inode_times(struct dentry *dentry, struct inode *inode, - bool rcu) +static void update_ovl_d_inode_times(struct dentry *dentry, bool rcu) { struct dentry *upperdentry; @@ -1585,6 +1584,7 @@ static void update_ovl_inode_times(struct dentry *dentry, struct inode *inode, * stale mtime/ctime. */ if (upperdentry) { + struct inode *inode = d_inode(dentry); struct inode *realinode = d_inode(upperdentry); if ((!timespec_equal(&inode->i_mtime, &realinode->i_mtime) || @@ -1607,7 +1607,8 @@ static int relatime_need_update(const struct path *path, struct inode *inode, if (!(path->mnt->mnt_flags & MNT_RELATIME)) return 1; - update_ovl_inode_times(path->dentry, inode, rcu); + update_ovl_d_inode_times(path->dentry, rcu); + /* * Is mtime younger than atime? If yes, update atime: */ @@ -1876,6 +1877,8 @@ int file_update_time(struct file *file) ret = update_time(inode, &now, sync_it); __mnt_drop_write_file(file); + update_ovl_d_inode_times(file->f_path.dentry, false); + return ret; } EXPORT_SYMBOL(file_update_time); -- 2.7.4