From: Amir Goldstein <amir73il@gmail.com>
To: Eryu Guan <eguan@redhat.com>
Cc: Jeff Layton <jlayton@poochiereds.net>,
"J . Bruce Fields" <bfields@fieldses.org>,
Miklos Szeredi <miklos@szeredi.hu>,
fstests@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-unionfs@vger.kernel.org
Subject: [PATCH 2/7] open_by_handle: verify dir content only with -r flag
Date: Sun, 7 Jan 2018 20:07:20 +0200 [thread overview]
Message-ID: <1515348445-1403-3-git-send-email-amir73il@gmail.com> (raw)
In-Reply-To: <1515348445-1403-1-git-send-email-amir73il@gmail.com>
Without -r flag file handles are opened, but file content is not read.
Treat dir file hanldes, similarly. without -r flag, open dir file
handle, but don't verify its content.
This is going to be used by tests for which dir content is changed
between encode and decode of dir file handle.
Signed-off-by: Amir Goldstein <amir73il@gmail.com>
---
src/open_by_handle.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/open_by_handle.c b/src/open_by_handle.c
index f9dfefc..5b7a592 100644
--- a/src/open_by_handle.c
+++ b/src/open_by_handle.c
@@ -472,7 +472,7 @@ int main(int argc, char **argv)
if (!nlink) {
printf("open_by_handle(%s) opened an unlinked dir!\n", dname);
return EXIT_FAILURE;
- } else {
+ } else if (rd) {
/*
* Sanity check dir fd - expect to access orig file IFF
* it was not unlinked nor renamed.
--
2.7.4
next prev parent reply other threads:[~2018-01-07 18:06 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-01-07 18:07 [PATCH 0/7] Overlayfs exportfs tests Amir Goldstein
2018-01-07 18:07 ` [PATCH 1/7] open_by_handle: store and load file handles from file Amir Goldstein
2018-01-11 11:59 ` Eryu Guan
2018-01-11 15:59 ` Amir Goldstein
2018-01-23 13:56 ` Amir Goldstein
2018-01-07 18:07 ` Amir Goldstein [this message]
2018-01-07 18:07 ` [PATCH 3/7] generic/exportfs: golden output is not silent Amir Goldstein
2018-01-07 18:07 ` [PATCH 4/7] generic/exportfs: store and load file handles from file Amir Goldstein
2018-01-07 18:07 ` [PATCH 5/7] generic/exportfs: add a test case for renamed parent dir Amir Goldstein
2018-01-07 18:07 ` [PATCH 6/7] overlay: test encode/decode overlay file handles Amir Goldstein
2018-01-16 7:38 ` Eryu Guan
2018-01-16 10:53 ` Amir Goldstein
2018-01-16 11:06 ` Eryu Guan
2018-01-16 15:09 ` Amir Goldstein
2018-01-07 18:07 ` [PATCH 7/7] overlay: test encode/decode of non-samefs " Amir Goldstein
2018-01-16 7:42 ` Eryu Guan
2018-01-16 8:46 ` Amir Goldstein
2018-01-11 11:43 ` [PATCH 0/7] Overlayfs exportfs tests Eryu Guan
2018-01-11 11:52 ` Amir Goldstein
2018-01-12 11:52 ` Eryu Guan
2018-01-12 13:07 ` Amir Goldstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1515348445-1403-3-git-send-email-amir73il@gmail.com \
--to=amir73il@gmail.com \
--cc=bfields@fieldses.org \
--cc=eguan@redhat.com \
--cc=fstests@vger.kernel.org \
--cc=jlayton@poochiereds.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-unionfs@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).