From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mail-pf1-f195.google.com ([209.85.210.195]:34515 "EHLO
        mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726562AbeJMCRA (ORCPT
        <rfc822;linux-fsdevel@vger.kernel.org>);
        Fri, 12 Oct 2018 22:17:00 -0400
Received: by mail-pf1-f195.google.com with SMTP id f78-v6so856286pfe.1
        for <linux-fsdevel@vger.kernel.org>; Fri, 12 Oct 2018 11:43:09 -0700 (PDT)
Message-ID: <1539369786.3203.4.camel@slavad-ubuntu-14.04>
Subject: Re: [PATCH 1/2] hfsplus: fix return value of hfsplus_get_block()
From: Viacheslav Dubeyko <slava@dubeyko.com>
To: "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?=
        <ernesto.mnd.fernandez@gmail.com>
Cc: linux-fsdevel@vger.kernel.org,
        Andrew Morton <akpm@linux-foundation.org>
Date: Fri, 12 Oct 2018 11:43:06 -0700
In-Reply-To: <20181012004818.h44lfnwlkjd4l63j@eaf>
References: <2cd1301404ec7cf1e39c8f11a01a4302f1460ad6.1539195310.git.ernesto.mnd.fernandez@gmail.com>
         <1539281136.3094.1.camel@slavad-ubuntu-14.04>
         <20181011194020.pwowja3onmqall4c@eaf>
         <1539304715.3094.4.camel@slavad-ubuntu-14.04>
         <20181012004818.h44lfnwlkjd4l63j@eaf>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 8bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Thu, 2018-10-11 at 21:48 -0300, Ernesto A. Fernández wrote:
> On Thu, Oct 11, 2018 at 05:38:35PM -0700, Viacheslav Dubeyko wrote:
> > On Thu, 2018-10-11 at 16:40 -0300, Ernesto A. Fernández wrote:
> > > On Thu, Oct 11, 2018 at 11:05:36AM -0700, Viacheslav Dubeyko wrote:
> > > > On Wed, 2018-10-10 at 15:23 -0300, Ernesto A. Fernández wrote:
> > > > > Direct writes to empty inodes fail with EIO.  The generic direct-io code
> > > > > is in part to blame (a patch has been submitted as "direct-io: allow
> > > > > direct writes to empty inodes"), but hfsplus is worse affected than the
> > > > > other filesystems because the fallback to buffered I/O doesn't happen.
> > > > > 
> > > > 
> > > > Could you please share more detailed explanation of the patch that
> > > > affects the HFS+ behavior? It's hard to follow what patch you mean.
> > > 
> > > It was sent to linux-fsdevel: "direct-io: allow direct writes to empty
> > > inodes."
> > > 
> > 
> > The git provides the commit ID and the annotation for every commit. It
> > will be great to see these details. Could you please share this
> > information?
> 
> The patch hasn't been merged yet.
> 

I am not completely sure how to review the patch in such case. I believe
that the best strategy is to wait till the mentioned patch will be
merged and to resend this patch again.

Thanks,
Vyacheslav Dubeyko.