From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-f195.google.com ([209.85.210.195]:46661 "EHLO mail-pf1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726502AbeJTKET (ORCPT ); Sat, 20 Oct 2018 06:04:19 -0400 Received: by mail-pf1-f195.google.com with SMTP id r64-v6so17224534pfb.13 for ; Fri, 19 Oct 2018 18:55:38 -0700 (PDT) Message-ID: <1540000535.3151.8.camel@slavad-ubuntu-14.04> Subject: Re: [PATCH 1/2] hfsplus: fix return value of hfsplus_get_block() From: Viacheslav Dubeyko To: "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?= Cc: linux-fsdevel@vger.kernel.org, Andrew Morton Date: Fri, 19 Oct 2018 18:55:35 -0700 In-Reply-To: <2cd1301404ec7cf1e39c8f11a01a4302f1460ad6.1539195310.git.ernesto.mnd.fernandez@gmail.com> References: <2cd1301404ec7cf1e39c8f11a01a4302f1460ad6.1539195310.git.ernesto.mnd.fernandez@gmail.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, 2018-10-10 at 15:23 -0300, Ernesto A. Fernández wrote: > Direct writes to empty inodes fail with EIO. The generic direct-io code > is in part to blame (a patch has been submitted as "direct-io: allow > direct writes to empty inodes"), but hfsplus is worse affected than the > other filesystems because the fallback to buffered I/O doesn't happen. > > The problem is the return value of hfsplus_get_block() when called with > !create. Change it to be more consistent with the other modules. > > Signed-off-by: Ernesto A. Fernández > --- > fs/hfsplus/extents.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/hfsplus/extents.c b/fs/hfsplus/extents.c > index 8a8893d522ef..a930ddd15681 100644 > --- a/fs/hfsplus/extents.c > +++ b/fs/hfsplus/extents.c > @@ -237,7 +237,9 @@ int hfsplus_get_block(struct inode *inode, sector_t iblock, > ablock = iblock >> sbi->fs_shift; > > if (iblock >= hip->fs_blocks) { > - if (iblock > hip->fs_blocks || !create) > + if (!create) > + return 0; > + if (iblock > hip->fs_blocks) > return -EIO; > if (ablock >= hip->alloc_blocks) { > res = hfsplus_file_extend(inode, false); Looks good. Finally, I think it should work properly. Reviewed-by: Vyacheslav Dubeyko Thanks, Vyacheslav Dubeyko.