From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from m12-18.163.com ([220.181.12.18]:40781 "EHLO m12-18.163.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729268AbeKXM57 (ORCPT ); Sat, 24 Nov 2018 07:57:59 -0500 From: Pan Bian To: Andrew Morton , ernesto.mnd.fernandez@gmail.com, Joe Perches Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Pan Bian Subject: [PATCH V2] hfs: do not free node before using Date: Sat, 24 Nov 2018 10:10:58 +0800 Message-Id: <1543025458-31592-1-git-send-email-bianpan2016@163.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: The function hfs_bmap_free frees node via hfs_bnode_put(node). However, it then reads node->this when dumping error message on an error path, which may result in a use-after-free bug. This patch frees node only when it is never used. Fixes: a1185ffa2fc("HFS rewrite") Signed-off-by: Pan Bian --- V2: correct the commit information in Fixes --- fs/hfs/btree.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/fs/hfs/btree.c b/fs/hfs/btree.c index 98b96ff..19017d2 100644 --- a/fs/hfs/btree.c +++ b/fs/hfs/btree.c @@ -338,13 +338,14 @@ void hfs_bmap_free(struct hfs_bnode *node) nidx -= len * 8; i = node->next; - hfs_bnode_put(node); if (!i) { /* panic */; pr_crit("unable to free bnode %u. bmap not found!\n", node->this); + hfs_bnode_put(node); return; } + hfs_bnode_put(node); node = hfs_bnode_find(tree, i); if (IS_ERR(node)) return; -- 2.7.4