From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 006B4C43381 for ; Tue, 26 Feb 2019 18:01:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ACB4A21850 for ; Tue, 26 Feb 2019 18:01:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=dubeyko-com.20150623.gappssmtp.com header.i=@dubeyko-com.20150623.gappssmtp.com header.b="nPpbZ5Mp" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728831AbfBZSBz (ORCPT ); Tue, 26 Feb 2019 13:01:55 -0500 Received: from mail-pf1-f174.google.com ([209.85.210.174]:35599 "EHLO mail-pf1-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728456AbfBZSBz (ORCPT ); Tue, 26 Feb 2019 13:01:55 -0500 Received: by mail-pf1-f174.google.com with SMTP id j5so6616123pfa.2 for ; Tue, 26 Feb 2019 10:01:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dubeyko-com.20150623.gappssmtp.com; s=20150623; h=message-id:subject:from:to:cc:date:in-reply-to:references :mime-version:content-transfer-encoding; bh=JFm/Vvf0ZZqYVfRbjFrhoUwEwrpZJHpJuS63sFsHpMI=; b=nPpbZ5MplzGMov4T61XnbPkv6I8VDe/BZ978V/ws/TwpiQ+yCiTr1MGMlQllqRQPNt 3vQgMNv/Zcaa/XFoJ0KJFN60CuaipBowZbNCok3ZNT4EVyqSslQKsc9ohqF5RXDrSWbZ zbblq+qclebBl3ILSyHEHAzdsGbz/OkO5zmF+v4FPvh4vq0Jh+SVnvnGyMlJipq5Yl0P AbcOwqSgz6RZgV26ZY8s/kXdzR6OTPkHvYGsdS5HcXZgqy4IAc6c5sU6uWr8Vf4WhvLv TEUkoL+YjkmBe+FZQR6X2Mwz6vwgQECLsNTyNtmKxxKS1DzJCYPX1FUiAR9YvcecaH55 cEXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:mime-version:content-transfer-encoding; bh=JFm/Vvf0ZZqYVfRbjFrhoUwEwrpZJHpJuS63sFsHpMI=; b=soBNr82gfT8yZ3/mQ12LID1Am4+TMgDvqN49DBQU6DSKkqSexWjsuY284cAzwMkc1R tvuGQPyFHECl7f/5Acs3D3ZLfcNsPBJWLTAVoHgCXlwQsM19qkPt92fQyi1JUidwPAaD TURGnqOlSe1xMFRxNDaSoJoN7Xt89tcRKZKIzq8xNLO5RO00PzMuXztpPFQCgFymd7H5 Dh2CjFQyHzF1tcqGPZDn/qbeoS9Us/6PUilOWEHIxBC/kvTmQcGUl++0MbBNX49kCN/2 lIBr+nL79kw5S66QDCEXdz1x6fGFbI0Edo9TSutNfrOHKI40D4li1W2ZMm5txBAiiKlm sR5A== X-Gm-Message-State: AHQUAuZJjYSym64WBl1YgBq/ZCKQ9KlYVVbH0sI2ElREZXQLackpbg5i 7D6kG7CHgSwW86NQ/QE23sWsdA== X-Google-Smtp-Source: AHgI3IbPLaAPTBP7wd0zDgBEBfSGW/HDJPKLXWOZ23PrkLdes1V5LLcWJXjKrA8sfnUMmKW5WuAIkA== X-Received: by 2002:a63:d04f:: with SMTP id s15mr5713056pgi.80.1551204114015; Tue, 26 Feb 2019 10:01:54 -0800 (PST) Received: from [192.168.1.136] (c-67-169-41-205.hsd1.ca.comcast.net. [67.169.41.205]) by smtp.gmail.com with ESMTPSA id w128sm20395435pfw.79.2019.02.26.10.01.52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Feb 2019 10:01:53 -0800 (PST) Message-ID: <1551204111.8087.10.camel@dubeyko.com> Subject: Re: The question about hfs+ patch (hfsplus: fix BUG on bnode parent update) From: Viacheslav Dubeyko To: tchou , "Ernesto A." =?ISO-8859-1?Q?Fern=E1ndez?= Cc: linux-fsdevel@vger.kernel.org, linux-fsdevel-owner@vger.kernel.org, slava@dubeiko.com Date: Tue, 26 Feb 2019 10:01:51 -0800 In-Reply-To: References: <73216487-9ed5-4492-b7c6-b757fdb3b566@Mail> <20190224004441.hhuakey36t2vvvag@eaf> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.18.5.2-0ubuntu3.2 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On Tue, 2019-02-26 at 11:32 +0800, tchou wrote: > Ernesto A. Fernández 於 2019-02-24 08:44 寫到: > > > > [skipped] > > > > > > [1] > > > ================================================================= > > > ================================= > > > > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.504049] hfsplus:  > > > trying to free free bnode 294912(2) > > > > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.510017] hfsplus:  > > > trying to free free bnode 294912(2) > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.515983] hfsplus:  > > > trying to free free bnode 294912(2) > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.521949] general  > > > protection fault: 0000 [#1] SMP > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.621069] CPU: 1 > > > PID:  > > > 18715 Comm: SYNO.FileStatio Tainted: P C O 3.10.102 #15152 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.630308] Hardware > > > name:  > > > Synology Inc. DS1517+/Type2 - Board Product Name1, BIOS M.405  > > > 2017/05/09 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.640423] task:  > > > ffff8802753fa040 ti: ffff880270880000 task.ti: ffff880270880000 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.648779] RIP:  > > > 0010:[] []  > > > hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.659489] RSP:  > > > 0018:ffff880270883c18 EFLAGS: 00010202 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.665415] RAX:  > > > 0000000000000000 RBX: 0000000000000002 RCX: 000000000000aeff > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.673391] RDX:  > > > 0000000000000000 RSI: ffff880270883c56 RDI: db73880000000000 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.681366] RBP:  > > > ffff88005f7b1920 R08: 0000000000000002 R09: 0000000000000002 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.689343] R10:  > > > ffff88005f7b18d0 R11: 0000000000000002 R12: 0000000000001ffc > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.697310] R13:  > > > ffff880270883c56 R14: 0000000000000002 R15: 0000000000000002 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.705286] FS:  > > > 00007f4fee0607c0(0000) GS:ffff88027fc40000(0000)  > > > knlGS:0000000000000000 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.714322] CS: 0010 > > > DS:  > > > 0000 ES: 0000 CR0: 000000008005003b > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.720744] CR2:  > > > 00007f4fee05d000 CR3: 0000000247210000 CR4: 00000000001007e0 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.728711] DR0:  > > > 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.736687] DR3:  > > > 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.744654] Stack: > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.746896]  > > > ffff88005f7b18c0 ffff880270883cd0 0000000000001ffc > > > 0000000000001f9c > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.755181]  > > > 0000000000000060 000000000000000e ffffffffa05146ff > > > aeff000000000031 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.763468]  > > > ffffffffa0516bf9 000000606228c340 ffff880270883cd0 > > > 00000000fffffffe > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.771763] Call > > > Trace: > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.774497]  > > > [] ? hfsplus_bnode_write_u16+0x1f/0x30 > > > [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.782671]  > > > [] ? hfsplus_brec_remove+0x129/0x190 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.790650]  > > > [] ? __hfsplus_delete_attr+0x90/0xf0 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.798629]  > > > [] ? hfsplus_delete_all_attrs+0x49/0xb0 > > > [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.806900]  > > > [] ? hfsplus_delete_cat+0x1c2/0x2b0 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.814782]  > > > [] ? hfsplus_unlink+0x1d0/0x1e0 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.822277]  > > > [] ? __inode_permission+0x1d/0xb0 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.828992]  > > > [] ? vfs_unlink+0x8a/0x100 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.835025]  > > > [] ? do_unlinkat+0x223/0x230 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.841255]  > > > [] ? mntput_no_expire+0x13/0x130 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.847873]  > > > [] ? task_work_run+0x9c/0xe0 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.854102]  > > > [] ? do_notify_resume+0x61/0x90 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.860624]  > > > [] ? fput+0x57/0xb0 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.865978]  > > > [] ? system_call_fastpath+0x16/0x1b > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.872884] Code: 48 > > > 63 ca  > > > 48 01 cf 48 83 fb 08 0f 83 fd 00 00 00 31 c0 41 f6 c3 04 74 09 8b > > > 06  > > > 89 07 b8 04 00 00 00 41 f6 c3 02 74 0c 0f b7 0c 06 <66> 89 0c 07 > > > 48 8d  > > > 40 02 41 83 e3 01 74 07 0f b6 0c 06 88 0c 07 > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.894293] RIP  > > > [] hfsplus_bnode_write+0x9e/0x1e0 [hfsplus] > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.902375] RSP  > > > > > > > > > 2017-08-30T10:32:30-04:00 BS-SAN kernel: [ 5471.906350] ---[ end > > > trace  > > > 0e65d1ee34a1e12e ]--- > > > > > > > > > ================================================================= > > > ================================= > > > Could you please share more details about the environment of the bug? Do you know what operation trigger the bug? How had volume been created? Can you reproduce the issue? It looks like the file deletion operation took place. Do you have any idea what file is under deletion and what features it has? Does this file contain any xattr? Thanks, Vyacheslav Dubeyko. > > > > > > > > > Best regards, > > > Ting-Chang Hou #8487 > > >