linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yafang Shao <laoar.shao@gmail.com>
To: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org, jack@suse.cz,
	Yafang Shao <laoar.shao@gmail.com>
Subject: [PATCH] fs/writeback: expose cgroup info in trace_writeback_pages_written()
Date: Thu, 28 Mar 2019 09:28:59 +0800	[thread overview]
Message-ID: <1553736539-32324-1-git-send-email-laoar.shao@gmail.com> (raw)

With cgroup v2 writeback, we can know these pages are written from which
cgroup.
So expose the cgroup_ino for better tracking.

Signed-off-by: Yafang Shao <laoar.shao@gmail.com>
Acked-by: Jan Kara <jack@suse.cz>
---
 fs/fs-writeback.c                | 4 ++--
 include/trace/events/writeback.h | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c
index 36855c1..e98a33e 100644
--- a/fs/fs-writeback.c
+++ b/fs/fs-writeback.c
@@ -1973,7 +1973,7 @@ void wb_workfn(struct work_struct *work)
 		 */
 		do {
 			pages_written = wb_do_writeback(wb);
-			trace_writeback_pages_written(pages_written);
+			trace_writeback_pages_written(wb, pages_written);
 		} while (!list_empty(&wb->work_list));
 	} else {
 		/*
@@ -1983,7 +1983,7 @@ void wb_workfn(struct work_struct *work)
 		 */
 		pages_written = writeback_inodes_wb(wb, 1024,
 						    WB_REASON_FORKER_THREAD);
-		trace_writeback_pages_written(pages_written);
+		trace_writeback_pages_written(wb, pages_written);
 	}
 
 	if (!list_empty(&wb->work_list))
diff --git a/include/trace/events/writeback.h b/include/trace/events/writeback.h
index 32db72c..a806713 100644
--- a/include/trace/events/writeback.h
+++ b/include/trace/events/writeback.h
@@ -255,15 +255,18 @@ static inline unsigned int __trace_wbc_assign_cgroup(struct writeback_control *w
 DEFINE_WRITEBACK_WORK_EVENT(writeback_wait);
 
 TRACE_EVENT(writeback_pages_written,
-	TP_PROTO(long pages_written),
-	TP_ARGS(pages_written),
+	TP_PROTO(struct bdi_writeback *wb, long pages_written),
+	TP_ARGS(wb, pages_written),
 	TP_STRUCT__entry(
 		__field(long,		pages)
+		__field(unsigned int,	cgroup_ino)
 	),
 	TP_fast_assign(
 		__entry->pages		= pages_written;
+		__entry->cgroup_ino	= __trace_wb_assign_cgroup(wb);
 	),
-	TP_printk("%ld", __entry->pages)
+	TP_printk("pages=%ld cgroup_ino=%u",
+		   __entry->pages, __entry->cgroup_ino)
 );
 
 DECLARE_EVENT_CLASS(writeback_class,
-- 
1.8.3.1


                 reply	other threads:[~2019-03-28  1:29 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1553736539-32324-1-git-send-email-laoar.shao@gmail.com \
    --to=laoar.shao@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).