From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8744C43387 for ; Thu, 17 Jan 2019 13:49:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 6FF2420851 for ; Thu, 17 Jan 2019 13:49:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726916AbfAQNth (ORCPT ); Thu, 17 Jan 2019 08:49:37 -0500 Received: from mx1.redhat.com ([209.132.183.28]:33724 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725878AbfAQNth (ORCPT ); Thu, 17 Jan 2019 08:49:37 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 294133DE0D; Thu, 17 Jan 2019 13:49:37 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-120-128.rdu2.redhat.com [10.10.120.128]) by smtp.corp.redhat.com (Postfix) with ESMTP id 11616601A6; Thu, 17 Jan 2019 13:49:35 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20190117075320.8327-1-hch@lst.de> References: <20190117075320.8327-1-hch@lst.de> To: Christoph Hellwig Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org Subject: Re: [PATCH] fs: move generic stat response attr handling to vfs_getattr_nosec MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <15566.1547732975.1@warthog.procyon.org.uk> Date: Thu, 17 Jan 2019 13:49:35 +0000 Message-ID: <15567.1547732975@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 17 Jan 2019 13:49:37 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christoph Hellwig wrote: > generic_fillattr is an optional helper that isn't used by all > file systems, move handling purely based on inode flags to > vfs_getattr_nosec, which is common code. > > This fixes setting this flag for file systems not using generic_fillattr > like xfs. The only problem I have with this change is that you've moved the flag setting to after the ->getattr() call, which means that the filesystem cannot override it. I'm not sure that particularly matters in the case of these two flags, but it might encourage similar things to be put there where it could matter. David