From: Pingfan Liu <kernelfans@gmail.com>
To: linux-xfs@vger.kernel.org
Cc: Pingfan Liu <kernelfans@gmail.com>,
"Darrick J. Wong" <darrick.wong@oracle.com>,
linux-fsdevel@vger.kernel.org
Subject: [PATCH] xfs/log: protect xc_cil in xlog_cil_push()
Date: Wed, 30 Oct 2019 14:29:40 +0800 [thread overview]
Message-ID: <1572416980-25274-1-git-send-email-kernelfans@gmail.com> (raw)
xlog_cil_push() is the reader and writer of xc_cil, and should be protected
against xlog_cil_insert_items().
Signed-off-by: Pingfan Liu <kernelfans@gmail.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>
To: linux-xfs@vger.kernel.org
Cc: linux-fsdevel@vger.kernel.org
---
fs/xfs/xfs_log_cil.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/xfs/xfs_log_cil.c b/fs/xfs/xfs_log_cil.c
index ef652abd..004af09 100644
--- a/fs/xfs/xfs_log_cil.c
+++ b/fs/xfs/xfs_log_cil.c
@@ -723,6 +723,7 @@ xlog_cil_push(
*/
lv = NULL;
num_iovecs = 0;
+ spin_lock(&cil->xc_cil_lock);
while (!list_empty(&cil->xc_cil)) {
struct xfs_log_item *item;
@@ -737,6 +738,7 @@ xlog_cil_push(
item->li_lv = NULL;
num_iovecs += lv->lv_niovecs;
}
+ spin_unlock(&cil->xc_cil_lock);
/*
* initialise the new context and attach it to the CIL. Then attach
--
2.7.5
next reply other threads:[~2019-10-30 6:30 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-30 6:29 Pingfan Liu [this message]
2019-10-30 12:53 ` [PATCH] xfs/log: protect xc_cil in xlog_cil_push() Brian Foster
2019-10-30 13:33 ` Pingfan Liu
2019-10-30 13:37 ` [PATCH] xfs/log: protect the logging content under xc_ctx_lock Pingfan Liu
2019-10-30 16:48 ` Darrick J. Wong
2019-10-31 3:48 ` Pingfan Liu
2019-10-31 21:40 ` Dave Chinner
2019-11-01 3:39 ` Pingfan Liu
2019-10-31 21:25 ` [PATCH] xfs/log: protect xc_cil in xlog_cil_push() Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1572416980-25274-1-git-send-email-kernelfans@gmail.com \
--to=kernelfans@gmail.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).