From mboxrd@z Thu Jan 1 00:00:00 1970 From: Neil Brown Subject: Re: keeping nfsd dentries on unused_list Date: Tue, 22 Oct 2002 09:15:54 +1000 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <15796.35498.749863.376566@notabene.cse.unsw.edu.au> References: <20021021173753.A15099@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: linux-fsdevel@vger.kernel.org Return-path: Received: From notabene.cse.unsw.edu.au ([129.94.242.45] == bartok.orchestra.cse.unsw.EDU.AU) (for ) (for ) By tone With Smtp ; Tue, 22 Oct 2002 09:16:02 +1000 To: Christoph Hellwig In-Reply-To: message from Christoph Hellwig on Monday October 21 List-Id: linux-fsdevel.vger.kernel.org On Monday October 21, hch@sgi.com wrote: > Hi Neil, > > since your export changes in 2.5. always have a non-empty > ->d_hash (linked into sb->s_anon) and thus are put on the unused > list by dput instead of directly reclaiming it. > > Is this behaviour intentional and will stay during 2.6? Keeping > those dentries alive will allow me to remove lots of code in XFS > to keep inodes that are written to by nfsd in cache as the final > iput will flush all delayed allocated space and thus decrease > nfs write performance massively - but as long as the dentry is > on the unused list after dput we still have an inode reference > and thus the delalloc block don't need to be converted. Yes. That behaviour is intentional and will stay. NeilBrown