From: linmiaohe <linmiaohe@huawei.com>
To: <viro@zeniv.linux.org.uk>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linmiaohe@huawei.com>
Subject: [PATCH] userfaultfd: eliminate meaningless check in userfaultfd_register()
Date: Mon, 1 Jun 2020 19:55:21 +0800 [thread overview]
Message-ID: <1591012521-517-1-git-send-email-linmiaohe@huawei.com> (raw)
From: Miaohe Lin <linmiaohe@huawei.com>
When we reach here, !(cur->vm_flags & VM_MAYWRITE) is already checked and
equals to false. So the condition here always equals to false and should
be eliminated.
Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
fs/userfaultfd.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/fs/userfaultfd.c b/fs/userfaultfd.c
index e39fdec8a0b0..e529e6bbb57b 100644
--- a/fs/userfaultfd.c
+++ b/fs/userfaultfd.c
@@ -1409,8 +1409,6 @@ static int userfaultfd_register(struct userfaultfd_ctx *ctx,
if (end & (vma_hpagesize - 1))
goto out_unlock;
}
- if ((vm_flags & VM_UFFD_WP) && !(cur->vm_flags & VM_MAYWRITE))
- goto out_unlock;
/*
* Check that this vma isn't already owned by a
--
2.19.1
reply other threads:[~2020-06-01 11:51 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1591012521-517-1-git-send-email-linmiaohe@huawei.com \
--to=linmiaohe@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).