From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09B1EC433DB for ; Sat, 13 Mar 2021 03:38:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B3D8664F85 for ; Sat, 13 Mar 2021 03:38:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233225AbhCMDhu (ORCPT ); Fri, 12 Mar 2021 22:37:50 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59492 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233208AbhCMDhZ (ORCPT ); Fri, 12 Mar 2021 22:37:25 -0500 Received: from mail-pj1-x1030.google.com (mail-pj1-x1030.google.com [IPv6:2607:f8b0:4864:20::1030]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4CC12C061761 for ; Fri, 12 Mar 2021 19:37:25 -0800 (PST) Received: by mail-pj1-x1030.google.com with SMTP id j6-20020a17090adc86b02900cbfe6f2c96so12001544pjv.1 for ; Fri, 12 Mar 2021 19:37:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=CBNgQRKeBzdDifSEOgKTaiLunUuYSZ8882u6ppXU5+U=; b=eSqXv0ctfLqgigrMQ8PF9EWZOhecpDPODocztQkLMOQ9YOXCKxb6aGcV0SRFdGr9O/ SXAjhD1m4PZ2QeA9AwCL6vq4XZQZmY51dZDRKQwIU6B5X1V8i43Wcr1eTiYFEy5GkbB7 kxv7AI1W4IvaKAO8GXohAheVSCtalgLMdOlZUIIK4moC9F2R653fNXf0U4PRnDoC84HG JZRfjM1tgk/7SSX1LoxK7Sd6fP+7xCV3b9JRSbzKaM6zIHvtBfN2+OpqOGLfmNCv8hwp Z34rYUhez5+AFzOFoTMVxrKfhPizb9woR1sPWIEa5uCOST00D5h/UDN89crL5p23cZI1 hfTA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=CBNgQRKeBzdDifSEOgKTaiLunUuYSZ8882u6ppXU5+U=; b=m0oT0uGf+ryK8aLnahXq+TyyKpr5z/iw0Im4/TJDr1oLZGCbotCMnbk09VSMSMXezt 2YHP/zXRYcJoIzibtf+H281ZnJZYqEKPtX+m4SaoSNEwzKsWvZg7+uS4Tfg6nKD/Hjc2 oj/RloWmi9rUWRtUT0ouTqE9I/NA7J3IVtBvyYY1GQjZx2bXhCMRoBLYVnhu0NTLEfnN O+6RIODz20OAMJB6TZ0RAQG0BqXg0atTtLchZ34VOem728+xEzKNEyJ/JInXknLWwAYK yzDc8ascg8oBADX/fqDvG0Wfs9OsxtOO4mJOufmexwgw9A6xxQAS88UosrLpcNt0eKp8 UuYw== X-Gm-Message-State: AOAM531XwPUUPfH6+8BA31BTEDMYAxYyjlTzjAtq5KDGFOLvtQJXeuIk azNi5iH1yc5To8LEOOfq6wUJDA== X-Google-Smtp-Source: ABdhPJwMgcLJD1SGGsLHCeRLzP10AkhbPEX9/l2NI2H9kx1l/lAMuKameOG8HK5rfGwY4CWLZuEjuA== X-Received: by 2002:a17:90b:1213:: with SMTP id gl19mr1513866pjb.55.1615606639689; Fri, 12 Mar 2021 19:37:19 -0800 (PST) Received: from [192.168.1.134] ([66.219.217.173]) by smtp.gmail.com with ESMTPSA id j23sm6881761pfn.94.2021.03.12.19.37.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 12 Mar 2021 19:37:19 -0800 (PST) Subject: Re: [RFC PATCH 0/3] block_dump: remove block dump To: "zhangyi (F)" , linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-block@vger.kernel.org, jack@suse.cz Cc: tytso@mit.edu, viro@zeniv.linux.org.uk, hch@infradead.org, mcgrof@kernel.org, keescook@chromium.org, yzaikin@google.com References: <20210313030146.2882027-1-yi.zhang@huawei.com> From: Jens Axboe Message-ID: <15f9c6ce-f22a-59cd-8ce7-eb908f663826@kernel.dk> Date: Fri, 12 Mar 2021 20:37:17 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20210313030146.2882027-1-yi.zhang@huawei.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 3/12/21 8:01 PM, zhangyi (F) wrote: > Hi, > > block_dump is an old debugging interface and can be replaced by > tracepoints, and we also found a deadlock issue relate to it[1]. As Jan > suggested, this patch set delete the whole block_dump feature, we can > use tracepoints to get the similar information. If someone still using > this feature cannot switch to use tracepoints or any other suggestions, > please let us know. Totally agree, that's long overdue. The feature is no longer useful and has been deprecated by much better methods. Unless anyone objects, I'll queue this up for 5.13. -- Jens Axboe