* [PATCH] fs: 9p: add generic splice_write file operation
[not found] <20201201151658.GA13180@nautica>
@ 2020-12-01 15:44 ` Dominique Martinet
2020-12-01 19:25 ` Christoph Hellwig
2020-12-01 20:37 ` Toke Høiland-Jørgensen
0 siblings, 2 replies; 3+ messages in thread
From: Dominique Martinet @ 2020-12-01 15:44 UTC (permalink / raw)
To: asmadeus
Cc: linux-kernel, v9fs-developer, linux-fsdevel,
Toke Høiland-Jørgensen
The default splice operations got removed recently, add it back to 9p
with iter_file_splice_write like many other filesystems do.
Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
Cc: Toke Høiland-Jørgensen <toke@redhat.com>
Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
---
fs/9p/vfs_file.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/fs/9p/vfs_file.c b/fs/9p/vfs_file.c
index 145f6f83aa9a..5f9c0c796a37 100644
--- a/fs/9p/vfs_file.c
+++ b/fs/9p/vfs_file.c
@@ -668,6 +668,7 @@ const struct file_operations v9fs_cached_file_operations = {
.lock = v9fs_file_lock,
.mmap = v9fs_file_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync,
};
@@ -681,6 +682,7 @@ const struct file_operations v9fs_cached_file_operations_dotl = {
.flock = v9fs_file_flock_dotl,
.mmap = v9fs_file_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync_dotl,
};
@@ -693,6 +695,7 @@ const struct file_operations v9fs_file_operations = {
.lock = v9fs_file_lock,
.mmap = generic_file_readonly_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync,
};
@@ -706,6 +709,7 @@ const struct file_operations v9fs_file_operations_dotl = {
.flock = v9fs_file_flock_dotl,
.mmap = generic_file_readonly_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync_dotl,
};
@@ -718,6 +722,7 @@ const struct file_operations v9fs_mmap_file_operations = {
.lock = v9fs_file_lock,
.mmap = v9fs_mmap_file_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync,
};
@@ -731,5 +736,6 @@ const struct file_operations v9fs_mmap_file_operations_dotl = {
.flock = v9fs_file_flock_dotl,
.mmap = v9fs_mmap_file_mmap,
.splice_read = generic_file_splice_read,
+ .splice_write = iter_file_splice_write,
.fsync = v9fs_file_fsync_dotl,
};
--
2.28.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: 9p: add generic splice_write file operation
2020-12-01 15:44 ` [PATCH] fs: 9p: add generic splice_write file operation Dominique Martinet
@ 2020-12-01 19:25 ` Christoph Hellwig
2020-12-01 20:37 ` Toke Høiland-Jørgensen
1 sibling, 0 replies; 3+ messages in thread
From: Christoph Hellwig @ 2020-12-01 19:25 UTC (permalink / raw)
To: Dominique Martinet
Cc: linux-kernel, v9fs-developer, linux-fsdevel,
Toke H??iland-J??rgensen
On Tue, Dec 01, 2020 at 04:44:56PM +0100, Dominique Martinet wrote:
> The default splice operations got removed recently, add it back to 9p
> with iter_file_splice_write like many other filesystems do.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Cc: Toke H??iland-J??rgensen <toke@redhat.com>
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fs: 9p: add generic splice_write file operation
2020-12-01 15:44 ` [PATCH] fs: 9p: add generic splice_write file operation Dominique Martinet
2020-12-01 19:25 ` Christoph Hellwig
@ 2020-12-01 20:37 ` Toke Høiland-Jørgensen
1 sibling, 0 replies; 3+ messages in thread
From: Toke Høiland-Jørgensen @ 2020-12-01 20:37 UTC (permalink / raw)
To: Dominique Martinet, asmadeus; +Cc: linux-kernel, v9fs-developer, linux-fsdevel
Dominique Martinet <asmadeus@codewreck.org> writes:
> The default splice operations got removed recently, add it back to 9p
> with iter_file_splice_write like many other filesystems do.
>
> Fixes: 36e2c7421f02 ("fs: don't allow splice read/write without explicit ops")
> Cc: Toke Høiland-Jørgensen <toke@redhat.com>
> Signed-off-by: Dominique Martinet <asmadeus@codewreck.org>
FWIW:
Acked-by: Toke Høiland-Jørgensen <toke@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-12-01 20:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20201201151658.GA13180@nautica>
2020-12-01 15:44 ` [PATCH] fs: 9p: add generic splice_write file operation Dominique Martinet
2020-12-01 19:25 ` Christoph Hellwig
2020-12-01 20:37 ` Toke Høiland-Jørgensen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).