* [PATCH] fs/locks: remove useless assignments
@ 2021-04-13 1:58 Tian Tao
2021-04-13 11:28 ` Jeff Layton
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-04-13 1:58 UTC (permalink / raw)
To: viro, jlayton, bfields; +Cc: linux-fsdevel, Tian Tao
Function parameter 'cmd' is rewritten with unused value at locks.c
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
fs/locks.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/fs/locks.c b/fs/locks.c
index 53cf033..5c42363 100644
--- a/fs/locks.c
+++ b/fs/locks.c
@@ -2369,7 +2369,6 @@ int fcntl_getlk(struct file *filp, unsigned int cmd, struct flock *flock)
if (flock->l_pid != 0)
goto out;
- cmd = F_GETLK;
fl->fl_flags |= FL_OFDLCK;
fl->fl_owner = filp;
}
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] fs/locks: remove useless assignments
2021-04-13 1:58 [PATCH] fs/locks: remove useless assignments Tian Tao
@ 2021-04-13 11:28 ` Jeff Layton
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Layton @ 2021-04-13 11:28 UTC (permalink / raw)
To: Tian Tao, viro, bfields; +Cc: linux-fsdevel
On Tue, 2021-04-13 at 09:58 +0800, Tian Tao wrote:
> Function parameter 'cmd' is rewritten with unused value at locks.c
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
> ---
> fs/locks.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/locks.c b/fs/locks.c
> index 53cf033..5c42363 100644
> --- a/fs/locks.c
> +++ b/fs/locks.c
> @@ -2369,7 +2369,6 @@ int fcntl_getlk(struct file *filp, unsigned int cmd, struct flock *flock)
> if (flock->l_pid != 0)
> goto out;
>
> - cmd = F_GETLK;
> fl->fl_flags |= FL_OFDLCK;
> fl->fl_owner = filp;
> }
Thanks, merged into the locks-next branch and should make v5.13.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-13 1:58 [PATCH] fs/locks: remove useless assignments Tian Tao
2021-04-13 11:28 ` Jeff Layton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).