From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nikita Danilov Subject: Re: Implementing writepage Date: Mon, 27 Oct 2003 11:52:05 +0300 Sender: linux-fsdevel-owner@vger.kernel.org Message-ID: <16284.56501.10135.563220@laputa.namesys.com> References: <20031025092152.D638B6D5B@blood.actrix.co.nz> <1067098698.3266.19.camel@lapdancer.baythorne.internal> <16284.55463.520076.541516@laputa.namesys.com> <1067243966.15551.256.camel@hades.cambridge.redhat.com> <16284.55985.863779.2130@laputa.namesys.com> <1067244402.15551.258.camel@hades.cambridge.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Cc: manningc2@actrix.gen.nz, linux-fsdevel@vger.kernel.org Return-path: Received: from thebsh.namesys.com ([212.16.7.65]:40123 "HELO thebsh.namesys.com") by vger.kernel.org with SMTP id S261368AbTJ0IwG (ORCPT ); Mon, 27 Oct 2003 03:52:06 -0500 To: David Woodhouse In-Reply-To: <1067244402.15551.258.camel@hades.cambridge.redhat.com> List-Id: linux-fsdevel.vger.kernel.org David Woodhouse writes: > On Mon, 2003-10-27 at 11:43 +0300, Nikita Danilov wrote: > > By write(2)? May be I am missing something in this discussion, though. > > Either your commit_write() is synchronous or it does what writepage() > would do anyway... which is to start the I/O but not wait for it. I don't quite follow why. generic_commit_write() only marks buffers dirty. Actual IO is started by either ->writepages() called from within balance_dirty_pages() (or pdflush) or by ->writepage() called by VM scanner. > > -- > dwmw2 > Nikita.