From: Dai Ngo <dai.ngo@oracle.com>
To: chuck.lever@oracle.com, bfields@fieldses.org
Cc: jlayton@redhat.com, viro@zeniv.linux.org.uk,
linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH RFC v15 03/11] NFSD: Add lm_lock_expired call out
Date: Fri, 4 Mar 2022 16:37:05 -0800 [thread overview]
Message-ID: <1646440633-3542-4-git-send-email-dai.ngo@oracle.com> (raw)
In-Reply-To: <1646440633-3542-1-git-send-email-dai.ngo@oracle.com>
Add callout function nfsd4_lm_lock_expired for lm_lock_expired.
If lock request has conflict with courtesy client then expire the
courtesy client and return no conflict to caller.
Signed-off-by: Dai Ngo <dai.ngo@oracle.com>
---
fs/nfsd/nfs4state.c | 37 +++++++++++++++++++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index a65d59510681..583ac807e98d 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -6578,10 +6578,47 @@ nfsd4_lm_notify(struct file_lock *fl)
}
}
+/**
+ * nfsd4_lm_lock_expired - check if lock conflict can be resolved.
+ *
+ * @fl: pointer to file_lock with a potential conflict
+ * Return values:
+ * %false: real conflict, lock conflict can not be resolved.
+ * %true: no conflict, lock conflict was resolved.
+ *
+ * Note that this function is called while the flc_lock is held.
+ */
+static bool
+nfsd4_lm_lock_expired(struct file_lock *fl)
+{
+ struct nfs4_lockowner *lo;
+ struct nfs4_client *clp;
+ bool rc = false;
+
+ if (!fl)
+ return false;
+ lo = (struct nfs4_lockowner *)fl->fl_owner;
+ clp = lo->lo_owner.so_client;
+
+ /* need to sync with courtesy client trying to reconnect */
+ spin_lock(&clp->cl_cs_lock);
+ if (test_bit(NFSD4_CLIENT_EXPIRED, &clp->cl_flags))
+ rc = true;
+ else {
+ if (test_bit(NFSD4_CLIENT_COURTESY, &clp->cl_flags)) {
+ set_bit(NFSD4_CLIENT_EXPIRED, &clp->cl_flags);
+ rc = true;
+ }
+ }
+ spin_unlock(&clp->cl_cs_lock);
+ return rc;
+}
+
static const struct lock_manager_operations nfsd_posix_mng_ops = {
.lm_notify = nfsd4_lm_notify,
.lm_get_owner = nfsd4_lm_get_owner,
.lm_put_owner = nfsd4_lm_put_owner,
+ .lm_lock_expired = nfsd4_lm_lock_expired,
};
static inline void
--
2.9.5
next prev parent reply other threads:[~2022-03-05 0:37 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-05 0:37 [PATCH RFC v15 0/11] NFSD: Initial implementation of NFSv4 Courteous Server Dai Ngo
2022-03-05 0:37 ` [PATCH RFC v15 01/11] fs/lock: add helper locks_any_blockers to check for blockers Dai Ngo
2022-03-09 20:56 ` Chuck Lever III
2022-03-10 3:11 ` dai.ngo
2022-03-10 4:08 ` Chuck Lever III
2022-03-10 4:45 ` dai.ngo
2022-03-05 0:37 ` [PATCH RFC v15 02/11] NFSD: Add client flags, macro and spinlock to support courteous server Dai Ngo
2022-03-05 0:37 ` Dai Ngo [this message]
2022-03-05 0:37 ` [PATCH RFC v15 04/11] NFSD: Update nfsd_breaker_owns_lease() to handle courtesy clients Dai Ngo
2022-03-09 21:46 ` Chuck Lever III
2022-03-10 5:09 ` dai.ngo
2022-03-10 14:02 ` Chuck Lever III
2022-03-05 0:37 ` [PATCH RFC v15 05/11] NFSD: Update nfs4_get_vfs_file() " Dai Ngo
2022-03-05 0:37 ` [PATCH RFC v15 06/11] NFSD: Update find_clp_in_name_tree() " Dai Ngo
2022-03-09 22:08 ` Chuck Lever III
2022-03-10 3:11 ` dai.ngo
2022-03-05 0:37 ` [PATCH RFC v15 07/11] NFSD: Update find_in_sessionid_hashtbl() " Dai Ngo
2022-03-09 22:42 ` Chuck Lever III
2022-03-10 3:12 ` dai.ngo
2022-03-10 3:33 ` Chuck Lever III
2022-03-10 4:43 ` dai.ngo
2022-03-05 0:37 ` [PATCH RFC v15 08/11] NFSD: Update find_client_in_id_table() " Dai Ngo
2022-03-05 0:37 ` [PATCH RFC v15 09/11] NFSD: Refactor nfsd4_laundromat() Dai Ngo
2022-03-05 0:37 ` [PATCH RFC v15 10/11] NFSD: Update laundromat to handle courtesy clients Dai Ngo
2022-03-05 0:37 ` [PATCH RFC v15 11/11] NFSD: Show state of courtesy clients in client info Dai Ngo
2022-03-09 20:14 ` Chuck Lever III
2022-03-09 20:51 ` dai.ngo
2022-03-10 3:09 ` dai.ngo
2022-03-10 3:27 ` Chuck Lever III
2022-03-10 15:00 ` Bruce Fields
2022-03-10 17:59 ` dai.ngo
2022-03-10 14:43 ` Chuck Lever III
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1646440633-3542-4-git-send-email-dai.ngo@oracle.com \
--to=dai.ngo@oracle.com \
--cc=bfields@fieldses.org \
--cc=chuck.lever@oracle.com \
--cc=jlayton@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).