From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ashish Sangwan Subject: Re: Re: Re: [PATCH] fsnotify: fix a crash due to invalid virtual address Date: Wed, 24 Jun 2015 10:13:50 +0000 (GMT) Message-ID: <166776534.176181435140830045.JavaMail.weblogic@ep2mlwas04a> Reply-To: a.sangwan@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: base64 Cc: "linux-fsdevel@vger.kernel.org" , Andrew Morton , Eric Paris , AMIT SAHRAWAT , Namjae Jeon , PANKAJ MISHRA , Lino Sanfilippo To: Jan Kara Return-path: Received: from mailout2.samsung.com ([203.254.224.25]:37001 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750974AbbFXKOu (ORCPT ); Wed, 24 Jun 2015 06:14:50 -0400 Received: from epcpsbgr4.samsung.com (u144.gpu120.samsung.co.kr [203.254.230.144]) by mailout2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQG00B381SO6S90@mailout2.samsung.com> for linux-fsdevel@vger.kernel.org; Wed, 24 Jun 2015 19:14:48 +0900 (KST) MIME-version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: SGkgSmFuLA0KDQo+IE9uIFR1ZSAyMy0wNi0xNSAxMjowNTo1MSwgQXNoaXNoIFNhbmd3YW4gd3Jv dGU6DQo+ID4gPiBMb29raW5nIGludG8gdGhpcyBpbiBtb3JlIGRldGFpbCwgaXQgbWlnaHQgYmUg d29ydGh3aGlsZSB0byByZXZpc2l0IGhvdw0KPiA+ID4gbWFya19tdXRleCBpcyB1c2VkIHNpbmNl IGF0IGxlYXN0IGZhbm90aWZ5IGFuZCBkbm90aWZ5IHVzZSBpdCBmb3IgbW9yZSB0aGFuDQo+ID4g PiBqdXN0IGEgcHJvdGVjdGlvbiBvZiBsaXN0IG9mIGdyb3VwIG1hcmtzIGFuZCB1bnRhbmdsaW5n IHRoaXMgd291bGQgc2ltcGxpZnkNCj4gPiA+IHRoaW5ncy4gQnV0IHRoYXQncyBhIGxvbmdlciB0 ZXJtIGdvYWwuDQo+ID4gPiANCj4gPiA+IEEgcmVsYXRpdmVseSBzaW1wbGUgZml4IGZvciB5b3Vy IGlzc3VlIGlzIHRvIHNwbGl0IGdyb3VwIGxpc3Qgb2YgbWFya3MgaW50bw0KPiA+ID4gYSBsaXN0 IG9mIGlub2RlIG1hcmtzIGFuZCBhIGxpc3Qgb2YgbW91bnQgbWFya3MuIFRoZW4gZGVzdHJveWlu ZyBiZWNvbWVzDQo+ID4gPiBtdWNoIHNpbXBsZXIgYmVjYXVzZSB3ZSBhbHdheXMgZGlzY2FyZCB0 aGUgd2hvbGUgbGlzdCAob3IgYm90aCBvZiB0aGVtKSBhbmQNCj4gPiA+IHdlIGNhbiBlYXNpbHkg YXZvaWQgcHJvYmxlbXMgd2l0aCBsaXN0IGNvcnJ1cHRpb24gd2hlbiBkcm9wcGluZyB0aGUNCj4g PiA+IG1hcmtfbXV0ZXguIEkgY2FuIHdyaXRlIHRoZSBwYXRjaCBsYXRlciBvciB5b3UgY2FuIGRv IHRoYXQgaWYgeW91IGFyZQ0KPiA+IFNvcnJ5IEkgY291bGQgbm90IHVuZGVyc3RhbmQgd2h5IHRo ZSBncm91cCdzIGxpc3Qgb2YgbWFya3MgbmVlZHMgdG8gYmUgc3BsaXQuDQo+ID4gSSB3YXMgYnJv d3NpbmcgdGhyb3VnaCB0aGUgb2xkIGNvZGUsIGZyb20gdGhlIGRheXMgbWFya19tdXRleCB3YXMg bm90IHByZXNlbnQNCj4gPiBhbmQgaXQgbG9va2VkIGxpa2UgYmVsb3c6DQo+ID4gdm9pZCBmc25v dGlmeV9jbGVhcl9tYXJrc19ieV9ncm91cF9mbGFncyhzdHJ1Y3QgZnNub3RpZnlfZ3JvdXAgKmdy b3VwLA0KPiA+IAkJCQkJIHVuc2lnbmVkIGludCBmbGFncykNCj4gPiB7DQo+ID4gCXN0cnVjdCBm c25vdGlmeV9tYXJrICpsbWFyaywgKm1hcms7DQo+ID4gCUxJU1RfSEVBRChmcmVlX2xpc3QpOw0K PiA+IA0KPiA+IAlzcGluX2xvY2soJmdyb3VwLT5tYXJrX2xvY2spOw0KPiA+IAlsaXN0X2Zvcl9l YWNoX2VudHJ5X3NhZmUobWFyaywgbG1hcmssICZncm91cC0+bWFya3NfbGlzdCwgZ19saXN0KSB7 DQo+ID4gCQlpZiAobWFyay0+ZmxhZ3MgJiBmbGFncykgew0KPiA+IAkJCWxpc3RfYWRkKCZtYXJr LT5mcmVlX2dfbGlzdCwgJmZyZWVfbGlzdCk7DQo+ID4gCQkJbGlzdF9kZWxfaW5pdCgmbWFyay0+ Z19saXN0KTsNCj4gPiAJCQlmc25vdGlmeV9nZXRfbWFyayhtYXJrKTsNCj4gPiAJCX0NCj4gPiAJ fQ0KPiA+IAlzcGluX3VubG9jaygmZ3JvdXAtPm1hcmtfbG9jayk7DQo+ID4gDQo+ID4gCWxpc3Rf Zm9yX2VhY2hfZW50cnlfc2FmZShtYXJrLCBsbWFyaywgJmZyZWVfbGlzdCwgZnJlZV9nX2xpc3Qp IHsNCj4gPiAJCWZzbm90aWZ5X2Rlc3Ryb3lfbWFyayhtYXJrKTsNCj4gPiAJCWZzbm90aWZ5X3B1 dF9tYXJrKG1hcmspOw0KPiA+IAl9DQo+ID4gfQ0KPiA+IEhvdyBhYm91dCB1c2luZyBhIHRlbXBv cmFyeSBvbnN0YWNrIGxpc3RfaGVhZCBsaWtlIGFib3ZlPw0KPiANCj4gU28gd2UgY2FuIHVzZSBh IHRlbXBvcmFyeSBsaXN0X2hlYWQgZm9yIGVudHJpZXMgc2VsZWN0ZWQgZm9yIGRlc3RydWN0aW9u IGFzDQo+IHdlbGwuICpCdXQqIGluIGVpdGhlciBjYXNlIHlvdSBoYXZlIHRvIGJlIGNhcmVmdWwg YmVjYXVzZSBldmVuIHRoZQ0KPiB0ZW1wb3JhcnkgZnJlZV9saXN0IGNhbiBiZSBtb2RpZmllZCBi eSBjb25jdXJyZW50IG1hcmsgZGVzdHJ1Y3Rpb24gZS5nLiBmcm9tDQo+IGZzbm90aWZ5X2ZyZWVf bWFya3NfYnlfaW5vZGUoKSBjYWxsIGFzIGVhY2ggbWFyayBpcyBpbiB0d28gbGlzdHMgLSBvbmUN Cj4gaGFuZ2luZyBmcm9tIGlub2RlIC8gbW91bnQgYW5kIG9uZSBoYW5naW5nIGZyb20gdGhlIG5v dGlmaWNhdGlvbiBncm91cC4NClRydWUuDQo+IA0KPiBBY3R1YWxseSwgbG9va2luZyBpbnRvIGl0 IGV2ZW4gZnNub3RpZnlfZGVzdHJveV9tYXJrcygpIGRvZXNuJ3Qgc2VlbSB0byBiZQ0KPiBwcm9w ZXJseSBwcm90ZWN0ZWQgZnJvbSB0aGUgcmFjZS4gU2lnaC4NClRydWUuDQoNClNvIGFueXRoaW5n IHdoaWNoIGlzIGNhbGxpbmcgZnNub3RpZnlfZGVzdHJveV9tYXJrIGlzIG5vdCBwcm90ZWN0ZWQg YWdhaW5zdA0KY29uY3VycmVudCBkZWxldGlvbiBmcm9tIGZzbm90aWZ5X2NsZWFyX21hcmtzX2J5 X2dyb3VwX2ZsYWdzKCkgYW5kIHZpY2UgdmVyc2EuDQpQbHVzLCBhcyB5b3UgcmlnaHRseSBwb2lu dGVkLCB3ZSBoYXZlIGJvdGggdGhlIGlub2RlIG1hcmsgYW5kIHZmc21vdW50IHNoYXJpbmcgdGhl IHNhbWUgbGlzdC4NClNvIGV2ZW4gaWYgZnNub3RpZnlfY2xlYXJfbWFya3NfYnlfZ3JvdXBfZmxh Z3MgaXMgZm9yIHJlbW92aW5nIGlub2RlIG1hcmssIGENCnBhcmFsbGVsIGZzbm90aWZ5X2Rlc3Ry b3lfbWFyayBmb3IgdmZzbW91bnQgY2FuIGNhdXNlIGNyYXNoIGFzIHRoZXkgYXJlIHNoYXJpbmcN CnNhbWUgbGlzdC4NCkNhbiB5b3UgY2hlY2sgYmVsb3cgcGF0Y2g/IEl0IGlzIHVudGVzdGVkLCBq dXN0IHdhbnQgdG8ga25vdyBpZiB0aGUgYXBwcm9hY2ggaXMNCmNvcnJlY3Qgb3Igbm90LiBJZiBp dCBzZWVtcyBvaywgSSBjYW4gc2VuZCBhIHRlc3RlZCBwYXRjaCBsYXRlci4NCmRpZmYgLS1naXQg YS9mcy9ub3RpZnkvbWFyay5jIGIvZnMvbm90aWZ5L21hcmsuYw0KaW5kZXggZDkwZGVhYS4uZDgz ZWM3ZCAxMDA2NDQNCi0tLSBhL2ZzL25vdGlmeS9tYXJrLmMNCisrKyBiL2ZzL25vdGlmeS9tYXJr LmMNCkBAIC0xMjQsMTQgKzEyNCw2IEBAIHZvaWQgZnNub3RpZnlfZGVzdHJveV9tYXJrX2xvY2tl ZChzdHJ1Y3QgZnNub3RpZnlfbWFyayAqbWFyaywNCg0KICAgICAgICBzcGluX2xvY2soJm1hcmst PmxvY2spOw0KDQotICAgICAgIC8qIHNvbWV0aGluZyBlbHNlIGFscmVhZHkgY2FsbGVkIHRoaXMg ZnVuY3Rpb24gb24gdGhpcyBtYXJrICovDQotICAgICAgIGlmICghKG1hcmstPmZsYWdzICYgRlNO T1RJRllfTUFSS19GTEFHX0FMSVZFKSkgew0KLSAgICAgICAgICAgICAgIHNwaW5fdW5sb2NrKCZt YXJrLT5sb2NrKTsNCi0gICAgICAgICAgICAgICByZXR1cm47DQotICAgICAgIH0NCi0NCi0gICAg ICAgbWFyay0+ZmxhZ3MgJj0gfkZTTk9USUZZX01BUktfRkxBR19BTElWRTsNCi0NCiAgICAgICAg aWYgKG1hcmstPmZsYWdzICYgRlNOT1RJRllfTUFSS19GTEFHX0lOT0RFKSB7DQogICAgICAgICAg ICAgICAgaW5vZGUgPSBtYXJrLT5pLmlub2RlOw0KICAgICAgICAgICAgICAgIGZzbm90aWZ5X2Rl c3Ryb3lfaW5vZGVfbWFyayhtYXJrKTsNCkBAIC0xODgsNyArMTgwLDEwIEBAIHZvaWQgZnNub3Rp ZnlfZGVzdHJveV9tYXJrKHN0cnVjdCBmc25vdGlmeV9tYXJrICptYXJrLA0KICAgICAgICAgICAg ICAgICAgICAgICAgICAgc3RydWN0IGZzbm90aWZ5X2dyb3VwICpncm91cCkNCiB7DQogICAgICAg IG11dGV4X2xvY2tfbmVzdGVkKCZncm91cC0+bWFya19tdXRleCwgU0lOR0xFX0RFUFRIX05FU1RJ TkcpOw0KLSAgICAgICBmc25vdGlmeV9kZXN0cm95X21hcmtfbG9ja2VkKG1hcmssIGdyb3VwKTsN CisgICAgICAgaWYgKG1hcmstPmZsYWdzICYgRlNOT1RJRllfTUFSS19GTEFHX0FMSVZFKSB7DQor ICAgICAgICAgICAgICAgbWFyay0+ZmxhZ3MgJj0gfkZTTk9USUZZX01BUktfRkxBR19BTElWRTsN CisgICAgICAgICAgICAgICBmc25vdGlmeV9kZXN0cm95X21hcmtfbG9ja2VkKG1hcmssIGdyb3Vw KTsNCisgICAgICAgfQ0KICAgICAgICBtdXRleF91bmxvY2soJmdyb3VwLT5tYXJrX211dGV4KTsN CiB9DQoNCkBAIC0yOTMsMTQgKzI4OCwyNyBAQCB2b2lkIGZzbm90aWZ5X2NsZWFyX21hcmtzX2J5 X2dyb3VwX2ZsYWdzKHN0cnVjdCBmc25vdGlmeV9ncm91cCAqZ3JvdXAsDQogICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIHVuc2lnbmVkIGludCBmbGFncykNCiB7DQogICAg ICAgIHN0cnVjdCBmc25vdGlmeV9tYXJrICpsbWFyaywgKm1hcms7DQotDQorICAgICAgIExJU1Rf SEVBRChmcmVlX2xpc3QpOw0KKw0KICAgICAgICBtdXRleF9sb2NrX25lc3RlZCgmZ3JvdXAtPm1h cmtfbXV0ZXgsIFNJTkdMRV9ERVBUSF9ORVNUSU5HKTsNCi0gICAgICAgbGlzdF9mb3JfZWFjaF9l bnRyeV9zYWZlKG1hcmssIGxtYXJrLCAmZ3JvdXAtPm1hcmtzX2xpc3QsIGdfbGlzdCkgew0KKyAg ICAgICAvKiBQYXNzIDEgOiBjbGVhciB0aGUgYWxpdmUgZmxhZyBhbmQgbW92ZSB0byBmcmVlIGxp c3QgKi8NCisgICAgICAgbGlzdF9mb3JfZWFjaF9lbnRyeV9zYWZlKG1hcmssIGxtYXJrLCAmZ3Jv dXAtPm1hcmtzX2xpc3QsIGdfbGlzdCkNCiAgICAgICAgICAgICAgICBpZiAobWFyay0+ZmxhZ3Mg JiBmbGFncykgew0KKyAgICAgICAgICAgICAgICAgICAgICAgLyoNCisgICAgICAgICAgICAgICAg ICAgICAgICAqIElmIHRoZSBtYXJrIGlzIHByZXNlbnQgb24gZ3JvdXAncyBtYXJrIGxpc3QNCisg ICAgICAgICAgICAgICAgICAgICAgICAqIGl0IGhhcyB0byBiZSBhbGl2ZS4NCisgICAgICAgICAg ICAgICAgICAgICAgICAqLw0KKyAgICAgICAgICAgICAgICAgICAgICAgV0FSTl9PTighKG1hcmst PmZsYWdzICYgRlNOT1RJRllfTUFSS19GTEFHX0FMSVZFKSk7DQorICAgICAgICAgICAgICAgICAg ICAgICBsaXN0X2RlbF9pbml0KCZtYXJrLT5nX2xpc3QpOw0KKyAgICAgICAgICAgICAgICAgICAg ICAgbGlzdF9hZGQoJm1hcmstPmdfbGlzdCwgJmZyZWVfbGlzdCk7DQorICAgICAgICAgICAgICAg ICAgICAgICBtYXJrLT5mbGFncyAmPSB+RlNOT1RJRllfTUFSS19GTEFHX0FMSVZFOw0KKyAgICAg ICAgICAgICAgIH0NCisNCisgICAgICAgLyogUGFzcyAyOiByZW1vdmUgbWFyayAqLw0KKyAgICAg ICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUobWFyaywgbG1hcmssICZmcmVlX2xpc3QsIGdfbGlz dCkgew0KICAgICAgICAgICAgICAgICAgICAgICAgZnNub3RpZnlfZ2V0X21hcmsobWFyayk7DQog ICAgICAgICAgICAgICAgICAgICAgICBmc25vdGlmeV9kZXN0cm95X21hcmtfbG9ja2VkKG1hcmss IGdyb3VwKTsNCiAgICAgICAgICAgICAgICAgICAgICAgIGZzbm90aWZ5X3B1dF9tYXJrKG1hcmsp Ow0KLSAgICAgICAgICAgICAgIH0NCiAgICAgICAgfQ0KICAgICAgICBtdXRleF91bmxvY2soJmdy b3VwLT5tYXJrX211dGV4KTsNCiB9DQo=