From: David Howells <dhowells@redhat.com>
To: Song Liu <songliubraving@meta.com>
Cc: dhowells@redhat.com, Paulo Alcantara <pc@manguebit.com>,
Song Liu <song@kernel.org>,
"netfs@lists.linux.dev" <netfs@lists.linux.dev>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
Kernel Team <kernel-team@meta.com>
Subject: Re: [PATCH] netfs: Let netfs depends on PROC_FS
Date: Wed, 09 Apr 2025 12:56:53 +0100 [thread overview]
Message-ID: <1672921.1744199813@warthog.procyon.org.uk> (raw)
In-Reply-To: <1BEAB585-4A65-475C-85CC-332C98859546@fb.com>
Song Liu <songliubraving@meta.com> wrote:
> Thanks for the review. I guess we will need the following changes,
You need a little bit more. The error handling in the init function also
needs #ifdef'ing too lest the compiler warn about unused goto labels.
> probably in two separate patches?
Hmmm... yes. I'm suddenly uncertain about the order modules are inited. It
might actually need to be fs_initcall().
David
next prev parent reply other threads:[~2025-04-09 11:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 18:47 [PATCH] netfs: Let netfs depends on PROC_FS Song Liu
2025-04-07 19:18 ` Paulo Alcantara
[not found] ` <notmuch-sha1-7bf7bb81673494d9bbe96c6cfbeaf9005a6bd491>
2025-04-08 0:51 ` Paulo Alcantara
2025-04-08 7:31 ` David Howells
2025-04-08 15:05 ` Paulo Alcantara
2025-04-08 16:14 ` Song Liu
2025-04-09 11:56 ` David Howells [this message]
2025-04-09 15:03 ` David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1672921.1744199813@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=kernel-team@meta.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=netfs@lists.linux.dev \
--cc=pc@manguebit.com \
--cc=song@kernel.org \
--cc=songliubraving@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox