From: patchwork-bot+netdevbpf@kernel.org
To: David Howells <dhowells@redhat.com>
Cc: netdev@vger.kernel.org,
syzbot+ebc945fdb4acd72cba78@syzkaller.appspotmail.com,
marc.dionne@auristor.com, dvyukov@google.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, linux-afs@lists.infradead.org,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net] rxrpc: Fix potential data race in rxrpc_wait_to_be_connected()
Date: Thu, 27 Apr 2023 08:10:19 +0000 [thread overview]
Message-ID: <168258301915.27262.1188523901051859504.git-patchwork-notify@kernel.org> (raw)
In-Reply-To: <508133.1682427395@warthog.procyon.org.uk>
Hello:
This patch was applied to netdev/net.git (main)
by Paolo Abeni <pabeni@redhat.com>:
On Tue, 25 Apr 2023 13:56:35 +0100 you wrote:
> Inside the loop in rxrpc_wait_to_be_connected() it checks call->error to
> see if it should exit the loop without first checking the call state. This
> is probably safe as if call->error is set, the call is dead anyway, but we
> should probably wait for the call state to have been set to completion
> first, lest it cause surprise on the way out.
>
> Fix this by only accessing call->error if the call is complete. We don't
> actually need to access the error inside the loop as we'll do that after.
>
> [...]
Here is the summary with links:
- [net] rxrpc: Fix potential data race in rxrpc_wait_to_be_connected()
https://git.kernel.org/netdev/net/c/2b5fdc0f5caa
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
prev parent reply other threads:[~2023-04-27 8:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-25 12:56 [PATCH net] rxrpc: Fix potential data race in rxrpc_wait_to_be_connected() David Howells
2023-04-27 8:10 ` patchwork-bot+netdevbpf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168258301915.27262.1188523901051859504.git-patchwork-notify@kernel.org \
--to=patchwork-bot+netdevbpf@kernel.org \
--cc=davem@davemloft.net \
--cc=dhowells@redhat.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-afs@lists.infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.dionne@auristor.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+ebc945fdb4acd72cba78@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox