linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hao Xu <hao.xu@linux.dev>
To: Alan Huang <mmpgouride@gmail.com>
Cc: fuse-devel@lists.sourceforge.net, miklos@szeredi.hu,
	linux-fsdevel@vger.kernel.org, bernd.schubert@fastmail.fm,
	Jiachen Zhang <zhangjiachen.jaycee@bytedance.com>,
	Wanpeng Li <wanpengli@tencent.com>,
	cgxu519@mykernel.net
Subject: Re: [PATCH 1/3] fuse: invalidate page cache pages before direct write
Date: Tue, 1 Aug 2023 18:40:39 +0800	[thread overview]
Message-ID: <16c14e85-f128-e5e8-c271-f03da0e476f7@linux.dev> (raw)
In-Reply-To: <B98453E7-ABF1-426E-A752-553476D390C5@gmail.com>

Hi Alan,


On 8/1/23 18:14, Alan Huang wrote:
>> 2023年8月1日 16:06，Hao Xu <hao.xu@linux.dev> 写道：
>>
>> From: Hao Xu <howeyxu@tencent.com>
>>
>> In FOPEN_DIRECT_IO, page cache may still be there for a file since
>> private mmap is allowed. Direct write should respect that and invalidate
>> the corresponding pages so that page cache readers don't get stale data.
> Do other filesystems also invalidate page cache in this case?


For now all filesystems that use iomap do this invalidation, see: 
__iomap_dio_rw()

e.g. ext4, xfs


Regards,

Hao


  reply	other threads:[~2023-08-01 10:40 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-01  8:06 [PATCH v4 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-08-01  8:06 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Hao Xu
2023-08-01 10:14   ` Alan Huang
2023-08-01 10:40     ` Hao Xu [this message]
2023-08-01 11:04       ` Alan Huang
2023-08-03  4:45   ` Jiachen Zhang
2023-08-01  8:06 ` [PATCH 2/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Hao Xu
2023-08-01  8:06 ` [PATCH 3/3] fuse: write back dirty pages before direct write in direct_io_relax mode Hao Xu
2023-08-03  4:43   ` Jiachen Zhang
2023-08-16 10:29 ` [PATCH v4 0/3] fuse: add a new fuse init flag to relax restrictions in no cache mode Miklos Szeredi
  -- strict thread matches above, loose matches on Subject: below --
2023-06-30  9:45 [PATCH v3 " Hao Xu
2023-06-30  9:46 ` [PATCH 1/3] fuse: invalidate page cache pages before direct write Hao Xu
2023-06-30 10:32   ` Bernd Schubert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16c14e85-f128-e5e8-c271-f03da0e476f7@linux.dev \
    --to=hao.xu@linux.dev \
    --cc=bernd.schubert@fastmail.fm \
    --cc=cgxu519@mykernel.net \
    --cc=fuse-devel@lists.sourceforge.net \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=mmpgouride@gmail.com \
    --cc=wanpengli@tencent.com \
    --cc=zhangjiachen.jaycee@bytedance.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).